Conversation
|
Changed back to draft so we don't accidently merge it. |
| <legend class="com-finder__search-legend sr-only"> | ||
| <?php echo Text::_('COM_FINDER_SEARCH_FORM_LEGEND'); ?> | ||
| </legend> |
There was a problem hiding this comment.
| <legend class="com-finder__search-legend sr-only"> | |
| <?php echo Text::_('COM_FINDER_SEARCH_FORM_LEGEND'); ?> | |
| </legend> | |
| <legend class="com-finder__search-legend sr-only"> | |
| <?php echo Text::_('COM_FINDER_SEARCH_FORM_LEGEND'); ?> | |
| </legend> |
Please use tabs for indentation.
| <legend class="com-finder__search-advanced sr-only"> | ||
| <?php echo Text::_('COM_FINDER_SEARCH_ADVANCED_LEGEND'); ?> | ||
| </legend> |
There was a problem hiding this comment.
| <legend class="com-finder__search-advanced sr-only"> | |
| <?php echo Text::_('COM_FINDER_SEARCH_ADVANCED_LEGEND'); ?> | |
| </legend> | |
| <legend class="com-finder__search-advanced sr-only"> | |
| <?php echo Text::_('COM_FINDER_SEARCH_ADVANCED_LEGEND'); ?> | |
| </legend> |
- for styling it is much easier to style a list item then the combination of dt and dd - screen readers can read out the number of list items in the ordered list
|
DL => OL conversion
Changing it from DL back to OL makes it easier for frontend developers to style each search result. |
|
top right in Github: At least 6 approving reviews are required to merge this pull request. |
That's not really relevant now since this PR here is just for development and maintenance but will not really be merged into the 4.0-dev branch. |
|
I think this should be made as separate PR for the CMS, because it doesn't depend on or interact with our other developments here and touch the admin area. @hans2103 As the code originally comes from you: Can you make such PR for the 4.0-dev branch of the CMS? |
|
Please .... And ask the JAT team for a test. |
|
There are quite a few changes in this PR that are not correct and definitely nothing to do with the template. Please lets not repeat the mistakes of the past and leave non-template changes to the main repo |
@chmst how to trigger them? Besides ask them via Glip.
@brianteeman Can you be more specific. I will fix them.
@brianteeman Planning to create multiple small PR's for joomla-cms repo |
When the PR is in the correct place I will |
|
created PR joomla/joomla-cms#30528 to solve the |
|
created PR joomla/joomla-cms#30534 to solve styling of search results |
|
created PR joomla/joomla-cms#30535 to add statement of search results |
|
All changes of this PR have been converted to three separate Joomla/Joomla-CMS pull requests. |
|
Thank you |
4 participants
Pull Request for Issue #20 .
Summary of Changes
This PR is to collect, discuss and text the enhancements of the frontend search as defined in isssue #20 .
Requirements:
Testing Instructions
Checkout the branch, or apply the changes of this branch to a current 4.0-dev branch or recent nightly of the CMS.
You can do that with patchtester 4:
(to be completed)
Expected result
(to be completed)
Actual result
(to be completed)
Documentation Changes Required
To be defined.