[4.0] Change com_associations to services #20457
Conversation
|
Tested: No noticeable change after this PR (I mean same issues as before). |
|
Thanks for the test. |
|
Can we/should we have a library class for the component classes that are just MVCFactory aware? Because we're going to have com_cpanel, com_modules, com_plugins, com_associations etc all having exactly the same classname, which seems kinda pointless (to be clear a generic version of https://github.com/Digital-Peak/joomla-cms/blob/9c95d4ece19fe25697fcecce8cb98c25d8b71d8a/administrator/components/com_associations/Extension/AssociationsComponent.php) |
|
@wilsonge good input. Changed and could remove two more classes. |
| */ | ||
| class MVCComponent extends Component implements MVCFactoryServiceInterface | ||
| { | ||
| use MVCFactoryServiceTrait; |
There was a problem hiding this comment.
Do we still want to keep the trait as it is used only here anymore?
There was a problem hiding this comment.
I think so - people might still choose to build up their own hierarchy of classes for their component implementations
wilsonge
left a comment
wilsonge
left a comment
There was a problem hiding this comment.
LGTM - need to solve the conflicts here from the requirement of the dispatcher class.
…ce/associations # Conflicts: # administrator/components/com_modules/services/provider.php
|
Synced |
5 participants
Moves com_associations to the service based extension setup.
See #20217 for details.