Skip to content

Conversation

@ReLater
Copy link
Contributor

@ReLater ReLater commented Mar 25, 2018

Related to #19965
See discussion there concerning B\C breaks in Joomla 3.x.

Summary of Changes

  • Adds a new switch Legacy (HTML4) versus HTML5.
  • Legacy is the default setting. Thus, this pr will not break older template overrides that use HTML4 attributes for IFRAME tags that have been removed in HTML5.
  • HTML5 uses CSS style instead.
  • Doesn't touch old parameter types and names but translates them via PHP for HTML5 mode if necessary.
  • Comment: Because most current browsers don't support CSS rule overflow for displaying/hiding scroll bars for IFRAME tags scrolling attribute cannot be removed in HTML5 mode.

Testing Instructions

Testing Instructions

  • Apply patch.
  • Create a module of type "Wrapper" with setting Mode = Legacy.
  • Create another module of type "Wrapper" with setting Mode = HTML5.
  • Compare outputs in frontend.
  • Test also other settings and compare output in frontend.

Expected result

  • No optical difference

Documentation Changes Required

????

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Mar 25, 2018
@ReLater ReLater closed this Apr 4, 2018
@ReLater ReLater deleted the patch-8 branch August 4, 2018 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants