Transition of Joomla's Wrapper from HTML4 to HTML5 #19965

BaleshSrle · 2018-03-22T15:21:29Z

Summary of Changes

Made a transition in Joomla's IFRAME element from HTML4 to HTML5 standard

Testing Instructions

Added wrapper modules on index.php and in menus (and/or submenus).
Using "px" or "%" in "height" field (required by HTML5 standard).

Expected result

Working 100 %

Actual result

Works like a charm, as seen @ view-source:https://sflogistika.dobojcaffe.com/v2/ & view-source:https://sflogistika.dobojcaffe.com/v2/index.php/video/srce-za-saobracajni

Documentation Changes Required

Need to modify 6 files to work without any problems or hiccups:

modules/mod_wrapper/mod_wrapper.xml
modules/mod_wrapper/mod_wrapper.php
modules/mod_wrapper/helper.php
modules/mod_wrapper/tmpl/default.php
components/com_wrapper/views/wrapper/tmpl/default.xml
components/com_wrapper/views/wrapper/tmpl/default.php

Changed "scroll" and "scrolling" to "overflow" and "frameborder" and "border" (required by HTML5 standard).

ReLater · 2018-03-24T00:55:32Z

@BaleshSrle
I think that this pr is a hard backwards compatibility break and cannot be merged like it is at the moment.

What do you think about changing it like this:

Adding an additional switch
HTML4 (which should be the default setting and uses the old parameters)
or
HTML5 (which uses the new parameters)
Displaying / Hiding related parameters with showon attributes in XML files.

C-Lodder · 2018-03-24T12:24:17Z

Isn't this a B/C break with the changing of param names/values?

BaleshSrle · 2018-03-24T13:52:10Z

Then why did you inserted HTML5 Shiv in Joomla? It's job is to make the websites with html5 supportable and presentable to older web browsers (for example Internet Explorer 8 or even Internet Explorer 6). There is no need for HTML4 code, because the htm5shiv is bridging the gap between the older web browsers (pre-HTML5) an new HTML5 code structure.

For more info, you can see (and even search) on some web links:
HTML iframe tag - w3schools.com
Presentational elements and attributes - WHATWG Wiki

For those who want to see does their Joomla web-site supports HTML5 coding standard, you can find tools @ W3C Markup Validator Service & Html Validator for Firefox and Chrome.

P.S.:Inform me if you want my contribution to Joomla 4 iframe element, if you want to modernise it. If not, then I promise to you all that I will modify Joomla's iframe element after every Joomla update.

mbabker · 2018-03-24T14:44:25Z

Isn't this a B/C break with the changing of param names/values?

Yes.

As implemented, this PR can't be accepted because it will cause existing sites using the wrapper component/module to stop using their existing configurations and switch to the default HTML5 configurations after an update. To be accepted in 3.x what @ReLater suggested needs to be applied.

ReLater · 2018-03-24T16:15:48Z

If not, then I promise to you all that I will modify Joomla's iframe element after every Joomla update.

Why not just changing your provided code once like suggested and making all users happy including yourself? ;-)

Please leave a comment here if you don't want to change it. Maybe(!) I'll find the time to take it over.

C-Lodder · 2018-03-24T16:26:28Z

@BaleshSrle I'm not disagreeing with you. I'm simply saying it's a B/C break as you're changing parameter names which will effect those with template overrides for those views.

BaleshSrle · 2018-03-24T17:42:56Z

@C-Lodder & @mbabker I have 17 iframe (or wrapper) elements on my 2 web-sites all together, and it took me all together less than 6 hours (maybe even less) to change all settings in every wrapper element from start to finish. Maybe you all are lazy and don't want to work on your web sites (that means to improve and maintain them).

I don't know about you, but I like to work on my web-sites.

About the template override issue, let's force the template designers to start creating templates by using HTML5 coding standard.

BTW, before I created this PR, I sent an email to [email protected] informing them about this and I sent them compressed modified xml and php files, and Luca Marzo sent me an e-mail and he informed me that I need to create a PR on Joomla's GitHub.

@ReLater I started this, and I will finish this. If you wish, you can join & assist me (because I don't understand PHP, but I understand HTML). But have in mind that this needs to be lite, because some people, who are using self-hosting servers, don't have enough storage space on those servers.

mbabker · 2018-03-24T17:53:40Z

It's not about being lazy, it's not about how much effort it might take a site owner to apply the changes. We have a backward compatibility promise, ONLY in a major version (i.e. 4.0) can breaking changes be accepted (preferably with a migration path if applicable). For this change proposal to land in a 3.x release, it must be made backward compatible. That means updating this PR in a way where existing HTML4 based configurations will keep working and users who elect to update their sites are free to do so with the new parameters.

Otherwise, this PR can only be applied to 4.0 if there is going to be no effort in making it backward compatible.

BaleshSrle · 2018-03-24T18:12:26Z

@mbabker I think that you are B/C this to Joomla 2.5.28. :-D

But if you like, I can create a PR for 4.0 , but after taking a glimpse at that code, I can say it is about 50% (or even more) similar to 3.x

ReLater · 2018-03-24T18:27:34Z

components/com_wrapper/views/wrapper/tmpl/default.php

-		height="<?php echo $this->escape($this->params->get('height')); ?>"
-		scrolling="<?php echo $this->escape($this->params->get('scrolling')); ?>"
-		frameborder="<?php echo $this->escape($this->params->get('frameborder', 1)); ?>"
+		style="width <?php echo $this->escape($this->params->get('width')); ?>; height: <?php echo $this->escape($this->params->get('height')); ?>; overflow: <?php echo $this->escape($this->params->get('overflow')); ?>; border: <?php echo $this->escape($this->params->get('border', 1)); ?>;"


Missing colon : after width

Hawk eyes ;-)

BaleshSrle

Hawk eyes ;-)
Error is changed...

BaleshSrle · 2018-03-24T19:08:28Z

components/com_wrapper/views/wrapper/tmpl/default.php

-		height="<?php echo $this->escape($this->params->get('height')); ?>"
-		scrolling="<?php echo $this->escape($this->params->get('scrolling')); ?>"
-		frameborder="<?php echo $this->escape($this->params->get('frameborder', 1)); ?>"
+		style="width <?php echo $this->escape($this->params->get('width')); ?>; height: <?php echo $this->escape($this->params->get('height')); ?>; overflow: <?php echo $this->escape($this->params->get('overflow')); ?>; border: <?php echo $this->escape($this->params->get('border', 1)); ?>;"


Hawk eyes ;-)

C-Lodder · 2018-03-24T19:34:13Z

@BaleshSrle Nothing to do with being lazy at all. It's simply obiding by semver rules.

Your changes will be fine against the 4.0-dev branch

ReLater · 2018-03-25T14:07:00Z

@BaleshSrle
See #19985 please.

joomla-cms-bot · 2018-03-25T17:27:03Z

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19965

Quy · 2018-03-25T17:27:03Z

Closing in favor for #19985.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19965.}

brianteeman · 2018-03-25T21:29:41Z

reopened

ReLater · 2018-03-25T21:31:22Z

@BaleshSrle

A strange find with my pr #19985 but also relevant for yours if you plan to commit it for Joomla 4

Most browsers don't support overflow CSS rule for IFRAME tags. One have to use scrolling="no|yes|auto" even if it has been removed in HTML5.

ReLater · 2018-03-25T23:10:42Z

See also pr #19991 (mod_wrapper, Joomla 3)

BaleshSrle · 2018-03-28T14:53:24Z

@ReLater You didn't read the link about overflow, because there is a table which displays the minimum version of web browser that supports CSS overflow property.

By the way, there is an HTML Shiv in Joomla.

ReLater · 2018-03-28T19:29:01Z

You didn't read the link about overflow, because there is a table which displays the minimum version of web browser that supports CSS overflow property.

You still don't understand. overflow: hidden; doesn't hide the scroll bars of tag IFRAME (!!!!!!) in supported browsers. Test it (!!!!) WITH JOOMLA 3 and or JOOMLA 4!

If a user chooses setting Scroll Bars = NO we don't want to see scroll bars in the Joomla frontend!

That's the only criterion for your and my pr (!!!!)

BaleshSrle · 2018-04-22T11:08:54Z

It does hide it... If it doesn't, then change the dimensions of iframe element (I mean on height and/or width of iframe) and leave overflow: hidden.

ReLater · 2018-04-22T15:30:35Z

Still the same answer: In Joomla 3 we have to guarantee that a user controls the behavior in backend like before. I've tested that with current Joomla 3 and HTML5 doesn't work like expected without adding HTML4 attribute
scrolling="yes"
scrolling="no"
in addition.

That's a known browsers issue, BTW.

I've closed my prs a month ago after some inverstigations because I don't like this attribute mix. But you can find their some "hints" to keep a Wrapper pr B\C for Joomla 3.

So, please feel free to provide a testable HTML5 version for Wrapper with the same common settings in backend for Joomla 3 or Joomla 4 or both. Makes no sense if we discuss theoretical things here ;-)

BaleshSrle · 2018-05-02T19:57:53Z

Look, I don't know what is the issue, but I suggest you open

link removed

in Mozilla-base (ie Firefox, Pale Moon or Sea Monkey) or Chromium-base (ie Google Chrome, Vivaldi or Opera) web browser and find the issue in my web-sites source code, because I can't find any.

brianteeman · 2018-05-03T10:55:50Z

Due to the nature of the link you posted I have had to remove it. Please dont post a similar link again.

BaleshSrle added 6 commits March 22, 2018 13:18

Update mod_wrapper.php

d7cc5ce

Changed "scroll" and "scrolling" to "overflow" and "frameborder" and "border" (required by HTML5 standard).

Update helper.php

58cd501

Update mod_wrapper.xml

5d39bee

Update default.php

b21a2d7

Update default.php

cd1a748

Update default.xml

465e07f

joomla-cms-bot added the PR-staging label Mar 22, 2018

ReLater reviewed Mar 24, 2018

View reviewed changes

Update default.php

c5c2845

BaleshSrle commented Mar 24, 2018

View reviewed changes

ReLater mentioned this pull request Mar 25, 2018

[3.x] com_wrapper. Add HTML5 mode without B\C break. #19985

Closed

joomla-cms-bot closed this Mar 25, 2018

brianteeman reopened this Mar 25, 2018

ReLater mentioned this pull request Mar 25, 2018

[3.x] mod_wrapper. Add HTML5 mode without B\C break #19991

Closed

BaleshSrle added 2 commits March 26, 2018 08:49

Update default.php

7b8fd33

Update default.php

f54b43a

BaleshSrle closed this Mar 28, 2018

BaleshSrle added 3 commits March 28, 2018 15:00

Update default.xml

20e29b1

Update default.php

3f4863c

Update mod_wrapper.xml

b417e1d

BaleshSrle reopened this Mar 28, 2018

BaleshSrle closed this Mar 28, 2018

BaleshSrle mentioned this pull request May 2, 2018

[4.0] Custom Elements everywhere: iframe wrapper #18916

Closed

laoneo mentioned this pull request Aug 9, 2018

[4.0] Transition of Joomla's Wrapper module and component from HTML4 to HTML5 #20212

Closed

Uh oh!

Transition of Joomla's Wrapper from HTML4 to HTML5 #19965

Transition of Joomla's Wrapper from HTML4 to HTML5 #19965

Uh oh!

Conversation

BaleshSrle commented Mar 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Uh oh!

ReLater commented Mar 24, 2018

Uh oh!

C-Lodder commented Mar 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BaleshSrle commented Mar 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mbabker commented Mar 24, 2018

Uh oh!

ReLater commented Mar 24, 2018

Uh oh!

C-Lodder commented Mar 24, 2018

Uh oh!

BaleshSrle commented Mar 24, 2018

Uh oh!

mbabker commented Mar 24, 2018

Uh oh!

BaleshSrle commented Mar 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ReLater Mar 24, 2018

Choose a reason for hiding this comment

Uh oh!

BaleshSrle Mar 24, 2018

Choose a reason for hiding this comment

Uh oh!

BaleshSrle left a comment

Choose a reason for hiding this comment

Uh oh!

BaleshSrle Mar 24, 2018

Choose a reason for hiding this comment

Uh oh!

C-Lodder commented Mar 24, 2018

Uh oh!

ReLater commented Mar 25, 2018

Uh oh!

joomla-cms-bot commented Mar 25, 2018

Uh oh!

Quy commented Mar 25, 2018

Uh oh!

brianteeman commented Mar 25, 2018

Uh oh!

ReLater commented Mar 25, 2018

Uh oh!

ReLater commented Mar 25, 2018

Uh oh!

BaleshSrle commented Mar 28, 2018

Uh oh!

ReLater commented Mar 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BaleshSrle commented Apr 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ReLater commented Apr 22, 2018

Uh oh!

BaleshSrle commented May 2, 2018 • edited by brianteeman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented May 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

BaleshSrle commented Mar 22, 2018 •

edited

Loading

C-Lodder commented Mar 24, 2018 •

edited

Loading

BaleshSrle commented Mar 24, 2018 •

edited

Loading

BaleshSrle commented Mar 24, 2018 •

edited

Loading

ReLater commented Mar 28, 2018 •

edited

Loading

BaleshSrle commented Apr 22, 2018 •

edited

Loading

BaleshSrle commented May 2, 2018 •

edited by brianteeman

Loading