[4.0] incorrect terminology #19728
Merged
[4.0] incorrect terminology #19728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR for joomla#19725 It is NOT a database table name you are entering - it is the database name. and replace specify with enter at the same time (plain english)
Contributor
|
@brianteeman Your branch is out-of-date. Can you merge the latest changes, please. |
Quy
reviewed
Feb 19, 2018
| INSTL_DATABASE_HOST_IS_NOT_LOCALHOST_DELETE_FILE="In order to confirm that you are the owner of this website please delete the file named "%1$s" we have created in the "%2$s" folder of your Joomla site." | ||
| INSTL_DATABASE_HOST_IS_NOT_LOCALHOST_GENERAL_MESSAGE="You are trying to use a database host which is not on your local server. For security reasons, you need to verify the ownership of your web hosting account. <a href="_QQ_"%s"_QQ_">Please read the documentation</a> for more information." | ||
| INSTL_DATABASE_NAME_DESC="Specify the database table name. Use table prefix to distinct Joomla sites." | ||
| INSTL_DATABASE_NAME_DESC="Enter the database table name." |
Contributor
Author
There was a problem hiding this comment.
less haste more speed
Quy
reviewed
Feb 19, 2018
| INSTL_DATABASE="Database Configuration" | ||
| INSTL_DATABASE_ERROR_POSTGRESQL_QUERY="PostgreSQL database query failed." | ||
| INSTL_DATABASE_HOST_DESC="Specify the Host Name, usually \"localhost\" or a name provided by your host." | ||
| INSTL_DATABASE_HOST_DESC="Enter the Host Name, usually \"localhost\" or a name provided by your host." |
Contributor
There was a problem hiding this comment.
lower case Host Name? This is the case with database name below.
Contributor
Author
There was a problem hiding this comment.
no it needs to be caps to differentiate from "name provided by your host"
Contributor
|
I have tested this item ✅ successfully on 35219ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19728. |
Contributor
|
I have tested this item ✅ successfully on 35219ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19728. |
|
I have tested this item ✅ successfully on 35219ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19728. |
|
I have tested this item ✅ successfully on 0f78eda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19728. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #19725
It is NOT a database table name you are entering - it is the database name.
and replace specify with enter at the same time (plain english)