[4.0] Use the config from the container in installation app #19689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 04b8b3d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19689. |
|
Successfully tested. 04b8b3d |
|
@dennisheiden please mark your Test as successfully:
|
|
I have tested this item ✅ successfully on 04b8b3d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19689. |
|
Ready to Commit after two successful tests. Thanks for tests, Guys. |
joomla-cms-bot
added
PR-4.0-dev
and removed
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with the introduction of a config service provider in #19658 the applications do get the config from the container. The installation app got forgotten, this pr fixes that.