[4.0] Change 'Module Class Suffix' to 'Module Class'#18300
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Oct 10, 2017
Merged
[4.0] Change 'Module Class Suffix' to 'Module Class'#18300wilsonge merged 3 commits intojoomla:4.0-devfrom
wilsonge merged 3 commits intojoomla:4.0-devfrom
Conversation
wilsonge
reviewed
Oct 10, 2017
| COM_MODULES_FIELD_CLIENT_ID_LABEL="Module Location" | ||
| COM_MODULES_FIELD_CONTENT_LABEL="Text" | ||
| COM_MODULES_FIELD_MODULE_LABEL="Module Type" | ||
| COM_MODULES_FIELD_MODULECLASS_SFX_LABEL="Module Class Suffix" |
Contributor
There was a problem hiding this comment.
Can we leave this string constant as is please? Huge numbers of modules use this. I know it kinda sucks as a descriptive thing - but it's also going to cause stupid pain
Quy
reviewed
Oct 10, 2017
templates/system/html/modules.php
Outdated
| // Temporarily store header class in variable | ||
| $headerClass = $params->get('header_class'); | ||
| $headerClass = $headerClass ? ' class="' . htmlspecialchars($headerClass, ENT_COMPAT, 'UTF-8') . '"' : ''; | ||
| $headerClass = $headerClass ? ' class=" ' . htmlspecialchars($headerClass, ENT_COMPAT, 'UTF-8') . '"' : ''; |
Quy
reviewed
Oct 10, 2017
| $headerClass = $headerClass ? ' class=" ' . htmlspecialchars($headerClass, ENT_COMPAT, 'UTF-8') . '"' : ''; | ||
|
|
||
| if (!empty ($module->content)) : ?> | ||
| <<?php echo $moduleTag; ?> class="moduletable<?php echo htmlspecialchars($params->get('moduleclass_sfx'), ENT_COMPAT, 'UTF-8') . $moduleClass; ?>"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #16894 .
Summary of Changes
Inline with #17026 this PR changes 'Module Class Suffix' to 'Module Class'
Testing Instructions
Add class to module using the 'Module Class' field (no space). Check frontend and ensure class has been added correctly.
Eg.
<div class="card yourClass">Expected result
Actual result
Documentation Changes Required
Yes