[4.0] Change 'Menu Class Suffix' to 'Menu Class'#17026
[4.0] Change 'Menu Class Suffix' to 'Menu Class'#17026wilsonge merged 3 commits intojoomla:4.0-devfrom
Conversation
|
I have tested this item ✅ successfully on fdc5e92 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026. |
language/en-GB/en-GB.mod_menu.ini
Outdated
| MOD_MENU_FIELD_ALLCHILDREN_LABEL="Show Sub-menu Items" | ||
| MOD_MENU_FIELD_CLASS_DESC="A suffix to be applied to the CSS class of the menu items." | ||
| MOD_MENU_FIELD_CLASS_LABEL="Menu Class Suffix" | ||
| MOD_MENU_FIELD_CLASS_DESC="A CSS class to be added to the menu." |
There was a problem hiding this comment.
To avoid confusion please can you put back the word item
MOD_MENU_FIELD_CLASS_DESC="A CSS class to be added to the menu item."
There was a problem hiding this comment.
Actually it is even better to have
MOD_MENU_FIELD_CLASS_DESC="Additional CSS to be added to the menu item."
as it could be more than one class
There was a problem hiding this comment.
Thanks @brianteeman Changed as suggested.
There was a problem hiding this comment.
oh wait you went with the first suggestion - not the second suggestion regarding multiple class although I am not 100% happy with that second suggestion
|
Will you be making a similar change to the modules? |
|
sorry just seen the modules pr |
|
I have tested this item ✅ successfully on 1ff2df8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026. |
|
@DGT41 can you please retest? |
|
I have tested this item ✅ successfully on 1ff2df8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026. |
|
RTC after two successful tests. |

Pull Request for Issue ##16894 (related) .
Summary of Changes
Changes 'Menu Class Suffix' to 'Menu Class'.
Testing Instructions
Add class to menu module using the 'Menu Class' field (no space). Check frontend and ensure class has been added correctly to the ul tag.
<ul class="nav flex-column yourClass">Expected result
Actual result
Documentation Changes Required
Yes