Skip to content

Comments

[4.0] Change 'Menu Class Suffix' to 'Menu Class'#17026

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
ciar4n:menu-class
Oct 9, 2017
Merged

[4.0] Change 'Menu Class Suffix' to 'Menu Class'#17026
wilsonge merged 3 commits intojoomla:4.0-devfrom
ciar4n:menu-class

Conversation

@ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Jul 9, 2017

Pull Request for Issue ##16894 (related) .

Summary of Changes

Changes 'Menu Class Suffix' to 'Menu Class'.

Testing Instructions

Add class to menu module using the 'Menu Class' field (no space). Check frontend and ensure class has been added correctly to the ul tag.

<ul class="nav flex-column yourClass">

Expected result

Actual result

Documentation Changes Required

Yes

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jul 9, 2017
@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on fdc5e92


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026.

MOD_MENU_FIELD_ALLCHILDREN_LABEL="Show Sub-menu Items"
MOD_MENU_FIELD_CLASS_DESC="A suffix to be applied to the CSS class of the menu items."
MOD_MENU_FIELD_CLASS_LABEL="Menu Class Suffix"
MOD_MENU_FIELD_CLASS_DESC="A CSS class to be added to the menu."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion please can you put back the word item

MOD_MENU_FIELD_CLASS_DESC="A CSS class to be added to the menu item."
 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is even better to have

MOD_MENU_FIELD_CLASS_DESC="Additional CSS to be added to the menu item."

as it could be more than one class

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brianteeman Changed as suggested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait you went with the first suggestion - not the second suggestion regarding multiple class although I am not 100% happy with that second suggestion

@brianteeman
Copy link
Contributor

Will you be making a similar change to the modules?

@brianteeman
Copy link
Contributor

sorry just seen the modules pr

@brianteeman brianteeman changed the title Change 'Menu Class Suffix' to 'Menu Class' [4.0] Change 'Menu Class Suffix' to 'Menu Class' Jul 10, 2017
@brianteeman brianteeman modified the milestone: Joomla 4.0 Jul 19, 2017
@davidsteltz
Copy link

I have tested this item ✅ successfully on 1ff2df8

test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026.

@ghost
Copy link

ghost commented Aug 26, 2017

@DGT41 can you please retest?

@C-Lodder
Copy link
Member

C-Lodder commented Oct 3, 2017

I have tested this item ✅ successfully on 1ff2df8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Oct 3, 2017
@ghost
Copy link

ghost commented Oct 3, 2017

RTC after two successful tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants