[#28120] XHTML 1.0 Transitional

[klauswilms]

I made some changes in administrator/components/com_admin/models/sysinfo.php.
if u check the html output of this page in w3c validator you get about 48 errors.
after changing the regex pattern line 146 and 147 and added a opening tr tag at line in administrator/components/com_admin/views/sysinfo/tmpl/default_system.php i got zero errors.

check it :)

greetings from klaus

[infograf768]

Please create a tracker in joomalcode.

[klauswilms]

[#28120] XHTML 1.0 Transitional added

[realityking]

What is this line for?

[klauswilms]

this line is from the original file.

[realityking]

It's not in https://github.com/joomla/joomla-cms/blob/master/administrator/components/com_admin/models/sysinfo.php. It's being added in this pull.

[klauswilms]

ok now i see what you meen, sorry
in your last post i saw line 150-151.

this line is for users with php zend module loaded.
the name attribute "module_Zend Optimizer" of an anker-tag is not xhtml valide, so replace it with "module_Zend_Optimizer"

[klauswilms]

ok there is no response, so I close this pull pull request

[realityking]

That's because all patches still have to go trough the issue tracker (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103) for testing before they can be accepted. As infograf768 mentioned you need to open an issue there or your patch won't be accepted.

It's not the most elegant system, but the github issue handling just doesn't cut it for the project.

[nicksavov]

Thanks for coding this, Klaus! :) This is fixed in JoomlaCode.
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=28120

Closing.