-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Needed for GSOC: Adding id in menu item edit array #11525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
tested ok |
|
I marked it for you |
|
I have tested this item ✅ successfully on ab4c091 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525. |
|
Thank you for merging This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525. |
|
I have tested this item ✅ successfully on ab4c091 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525. |
|
What is this needed for? Seems kind of counterintuitive to the UI? |
|
@wilsonge , this is needed in order to save associations on the side-by-side, without jform_id, I can't save new associations since I don't know which ID was generated |
|
I have tested this item ✅ successfully on ab4c091 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525. |
| 'language', | ||
| 'note' | ||
|
|
||
| 'note', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just by code review (i.e. not tested...): are you sure that comma after the last array element is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I found this: http://stackoverflow.com/questions/2829581/why-do-php-array-examples-leave-a-trailing-comma
In essence, valid syntax, although unusual, and good for convenience in case you wish to add one more element in the code at a later time.
|
Does this field need to be displayed in the UI. Doesnt seem any need for it to be displayed to me and just adds meaningless clutter This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11525. |
|
It does NOT need to be displayed but it is useful information that can be copied and does not clutter as it is at bottom of all fields. |
|
OK Can we make this a hidden field on the page - with an ID on the hidden field available for JS access |
|
@wilsonge |
|
Thank you for making that update |
* Needed for GSOC: Adding id in menu item edit array * hiding id field
* Needed for GSOC: Adding id in menu item edit array * hiding id field
We do need the id of the menu item in the
$this->fields = array(in a menu item edit.php) for the GSOC multilingual project.It was missing anyway to display the id in the page.
After patch, the readonly field will display:

Can be merged on review.
@andrepereiradasilva @alikon @jreys
@wilsonge