Skip to content

Needed for GSOC: Adding id in menu item edit array #11525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2016
Merged

Needed for GSOC: Adding id in menu item edit array #11525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab4c091
Needed for GSOC: Adding id in menu item edit array
infograf768 Aug 9, 2016
91ffd35
hiding id field
infograf768 Aug 12, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions administrator/components/com_menus/models/forms/item.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
<fieldset>
<field
name="id"
type="text"
class="readonly"
type="hidden"
label="JGLOBAL_FIELD_ID_LABEL"
description="JGLOBAL_FIELD_ID_DESC"
class="readonly"
default="0"
filter="int"
readonly="true"/>
readonly="true"
/>

<field
name="title"
Expand Down
4 changes: 2 additions & 2 deletions administrator/components/com_menus/views/item/tmpl/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,15 @@
<?php
// Set main fields.
$this->fields = array(
'id',
'menutype',
'parent_id',
'menuordering',
'published',
'home',
'access',
'language',
'note'

'note',
Copy link
Contributor

@smz smz Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just by code review (i.e. not tested...): are you sure that comma after the last array element is correct?

Copy link
Contributor

@mbabker mbabker Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor

@smz smz Aug 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I found this: http://stackoverflow.com/questions/2829581/why-do-php-array-examples-leave-a-trailing-comma

In essence, valid syntax, although unusual, and good for convenience in case you wish to add one more element in the code at a later time.

);

if ($this->item->type != 'component')
Expand Down