This repository was archived by the owner on Feb 9, 2019. It is now read-only.
Auto-association modals for contents #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the onclick code to the js script in finder
…nto astrid-plg_media-action_crop/crop.js
…otate.js Transform plg_media-action-rotate/rotate.js to ES6
…nto astrid-plg_media-action_crop/crop.js
Transform plg_media-action-crop/crop.js to ES6
…nto astrid-plg_media-action_resize/resize.js
…size.js Transform plg_media-action-resize/resize.js to ES6
…ponents/com_contact/tmpl/categories/default.php Remove inline scripts/components/com contact/tmpl/categories/default.php
…ponents/com_config/tmpl/config/default.php Remove inline scripts/components/com config/tmpl/config/default.php
…ponents/com_content/tmpl/form/edit.php Remove inline scripts/components/com content/tmpl/form/edit.php
chmst
reviewed
May 30, 2018
| } | ||
|
|
||
| $query->where('(c.' . $pk . ' = ' . (int) $referenceId . ' OR c.' . $pk . ' IS NULL) AND (c.' | ||
| . $langField . ' != l.lang_code OR c.' . $langField . ' IS NULL)' |
Contributor
There was a problem hiding this comment.
quote l.lang_code and c.extension too
* focus visible * revert jquery-migrate
* [4.0] remove <php 7 code This pr removes checks fromm the joomla_update code for < 7.0 php functionality. No point in the code being there as it will only ever be run on a site with > 7.0 php * remove safe mode check in the installer - not relevant in php 7 * remove unused regster globals strings
* [4.0] Installation language Remove hard coded string and replace with translatable string Add new string for the site name section - wrong string was being used Ensure all section strings are consistent Capital case Update en-US translation to be in sync with en-GB * Update en-US.ini * Update en-GB.ini * oops * oops * grrh * grrh * i dont speak american * update * missing translations * magic
* Namespace content site associations helper * CS * More CS
* Allow null for module content * Don't set a default value as null is allowed * postgres update script * postgres install script
* Finish the move of com_modules to services * CS * Revert file * cs
* Change com_templates to services * Revert file * cs
…multilingual_association into modal
Contributor
|
Not sure what this is for. |
Wang-Yu-Chao
requested review from
mbabker,
rdeutz,
wilsonge and
zero-24
as code owners
Contributor
|
make sure your PR only includes the needed changes and not branch sync stuff, anything with more than 20 changes files is hard to review |
Contributor
Author
|
@rdeutz |
Contributor
|
@Wang-Yu-Chao very close to a brilliant idea :-) |
Contributor
Author
|
@rdeutz Thanks! :) |
zero-24
pushed a commit
that referenced
this pull request
Sep 6, 2018
* Load correct core files of override files (#2) Start implements loadcorefile() in administrator/components/com_templates/Model/TemplateModel.php * CS (#3) Coding Standards * codingstandards * codingstandards (#4) * Test (#6) Phase 2 (2 part) Mechanism to find correct core file and implementation. * Remove Notice: Only available for html-folder * Remove Warning if core file not found (#11) Thanks. So one part of the issue joomla-projects/gsoc18_override_management#12 is done. * Implement the diff view in template manager Implement the diff view in template manager * coding standard (#17) * fix diff (#18) Fix bug in path in case of administrator template override. Fix bug in path in case of administrator template override. * Notification after update and TEST (#16) Find changed files of overridden files and show message. * coding standard (#21) * correction * correction (#26) * Correcthtmlpath (#27) * correction * change oldhtml to newhtml * List of updated override files. (#30) * addcss (#34) * Final Product (#39) Core and Diff view Updated override history list. Quick icon notification plugin. Override control plugin. * save 3 lines :) * New feature show status. (#47) show status in com_template view templates * link * corrected namespace * Button to Switch (#35) * wip add Switcher * wip style switcher * wip style switch make inline and change on off text * wip start with js * wip js * wip delete buttons and make js more robust * wip save to storage * wip delete old code * wip * wip lint * wip css * set default value for switcher * wip make switcher blue * wip * wip * build * correct names * create new functions * fist test code * use onchange * undo installer.min.js * add forgotten new line at the end of css file * correct align * correct compare.es6 - only deleted the toggle part * correct compare.js - only deleted the toggle part * wip * reduce timeout * wrap in funcitons * wip * add use strict to both js-files(compare and toggle) * add the timeout value of 500 again, because 200 are not enought in my case * use css class 'active' for toggle views * add strict * time out for editor * wip * improvments use newActive and switch * correction * width of switcher-spans * correct align * do not use global * wip * removed timeouts * JTEXT to TEXT * forgotton last line * deleted duplicated comments * css fix align * use unnamed functions in es6 * Sql files for fix database (#50) * sql files for database fix * delete space * Suggestion for displaying Dates in view updates files (#52) Correct Dates and do not use date of file any more * Store Date as UTC and show it in server time zone (#57) * modified and created date are created and stored in UTC * convert dates for displaying in model * spar a loop * normalize timezone in view * use language constants for dateformat * JToolbarHelper to ToolbarHelper * CS * namespace * plural * name * clean * text * fx * sin * files * s * Suggestion for language strings (#60) * language strings * correct typo * delete media folder plg_quickicon * add folder plg_quickicon to build/media_src * delete files in media folder * Move media folder - System (#66) * multi * cs * delete files in media folder for joomla toolbar (#67) * Fix button switchers style. (#70) * button * CS * changed uitab.addTab for updated files * Bring back core.js changes. (#69) * core.js * const * fix * form * core * hound * CS * scopr * grid * alpha * cs * lang * only override file * lang * override lang installer * Cs * sub * Update list of core extensions (#71) * Language changes (#76) * update * Update en-GB.com_templates.ini * override JLIB_HTML_PUBLISH_ITEM this is the hover text on the publish icon in the list of files * Change icon (#74) change the icon to use an outline for more consistency * lang * not core (#75) * not core * Update en-GB.plg_installer_override.ini * namespace * cs * Updated files (#82) * Update default_updated_files.php * Update en-GB.com_templates.ini * Update en-GB.com_templates.ini (#81) * Update en-GB.plg_quickicon_overridecheck.ini (#80) * Update en-GB.plg_quickicon_overridecheck.ini (#79) * remove space (#78) * Update en-GB.plg_quickicon_overridecheck.ini * Update en-GB.plg_quickicon_overridecheck.sys.ini * remove hardcoded id * null get function * state * clean * More changes "core" to "original" (#85) * cs * update * plural
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
27 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still testing. Just for presentation.
Summary of Changes
None
Testing Instructions
None
Expected result
None
Actual result
Documentation Changes Required
None