Introduce jquery formvalidator for com_weblinks #18
Conversation
#### Executive summary This PR converts the form validation on com_weblinks to use plain jquery (no mootools call on every form). Also NO MORE INLINE SCRIPTS! #### Testing 1. Apply first PR #4888 (!important) 2. Apply this PR 3. In the admin area go to com_weblinks and try to submit any form. If no javascript errors are logged in your browser and the functionality remains the same your test is a pass in any other case please report the errors here Please also check these: administrator/index.php?option=com_checkin should demonstrate multiselect without mt administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt Logout and log in to demonstrate the use of noframes without mt.
|
How can it be applied in a plain 3.3.6 ? |
|
@anibalsanchez Just overwrite those 2 files: |
|
@test success "A small step for a man, one giant leap toward the demise of MT" 😛 |
|
Manually patched, @test success |
|
@anibalsanchez @smanzi Can you retest this one? I removed the jquery .ready(), as it was requested for all these PR’s. If you test it in current staging just overwrite the two files touched here: Thanks and sorry for these extra tests |
|
@test success, on the current staging with a build of the latest weblinks |
|
@DGT41 i'm sorry for replying late on this one. I think the code in the second file can just be removed (see joomla/joomla-cms#5994) can you confirm (and remove if appropriate please)? |
|
@wilsonge This ain’t gonna work here as the plural view doesn’t implement the search tools button and thus the script is needed contrary to the category view, but for that there is #5994. I think that this feature (the search tools button) was introduced half baked and not side wide as there are many comments for unneeded filters etc… No search tools buttons (js needed) Search tools button (no js for ordering) |
Introduce jquery formvalidator for com_weblinks
public GET and rate-limit
4 participants
Executive summary
This PR converts the form validation on com_weblinks to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!
Testing
copy all and paste it to
/administrator/components/com_weblinks/views/weblink/tmpl/edit.phpAlso go to https://raw.githubusercontent.com/dgt41/weblinks/jquery_1/src/com_weblinks/admin/views/weblinks/tmpl/default.php
copy all and paste it to
/administrator/components/com_weblinks/views/weblinks/tmpl/edit.php3. In the admin area go to com_weblinks and try to submit any form.
If no javascript errors are logged in your browser and the functionality remains the same your test is a pass in any other case please report the errors here
Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
Logout and log in to demonstrate the use of noframes without mt.