-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom page margins #122
Add custom page margins #122
Conversation
Update master with dev
* Added a new method on the Maroto PDF interface to allow backwards compatibility instead of adding extra parameter to NewMaroto
Codecov Report
@@ Coverage Diff @@
## dev #122 +/- ##
==========================================
+ Coverage 95.22% 95.25% +0.04%
==========================================
Files 9 9
Lines 522 526 +4
==========================================
+ Hits 497 501 +4
Misses 21 21
Partials 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your feature is nice. I let some comments, could you see it?
Just one more thing, could you provide in your pull request a print screen of the effect of your modification? Maybe just run the sample1 and see if everything works properly with your modificati0on.
https://github.com/johnfercher/maroto/tree/master/internal/examples/sample1
Looks like the signature component doesn´t work well with this, I will take a look in this issue before merge your PR. |
94ae077
to
08dfd11
Compare
Update PR with improvements from comments. |
…ge-margins Feature/add custom page margins
Have a look to https://github.com/Jepzter/maroto/pull/1/files, I fixed the issue in the signatures |
Could you merge my PR into your branch? So I will be able to merge your branch into dev. |
feature/custom-margins
Niice, could you update the sample image with the fix? |
Sorry for being late, updated PR with image. |
Hey, happy new year =) I will merge this PR today. |
Happy new year to you to! Is there any reason this is still open I can fix? |
…ge-margins Add custom page margins
Description
compatibility instead of adding extra parameter to NewMaroto
This PR makes it possible to set other margins than the standard (10, 10, 10)
Picture of sample1 modified with SetPageMargins. 30 left, 20 top and 0 right.
m.SetPageMargins(30, 20, 0)
Related Issue
resolve #123
Checklist
func (s *struct) method() {}
name style.go fmt github.com/johnfercher/maroto/...
to format all files