Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add custom page margins #127

Merged
merged 4 commits into from
Dec 20, 2019
Merged

Feature/add custom page margins #127

merged 4 commits into from
Dec 20, 2019

Conversation

johnfercher
Copy link
Owner

Description

Related Issue

Checklist

check with "x", if applied to your change

  • All methods associated with structs has func (s *struct) method() {} name style.
  • Wrote unit tests for new/changed features.
  • Updated docs/doc.go
  • Updated pkg/pdf/example_test.go
  • Updated README.md
  • Updated all examples inside internal/examples
  • New public methods has comments upside them explaining what it does
  • Executed go fmt github.com/johnfercher/maroto/... to format all files

johnfercher and others added 4 commits November 11, 2019 00:17
@johnfercher
Merge pull request johnfercher#114 from johnfercher/dev
51992ea 
Update master with dev
@happsie
Add possibility to set custom page margins
bac3bb8 
* Added a new method on the Maroto PDF interface to allow backwards
compatibility instead of adding extra parameter to NewMaroto
@happsie
Fix conflicts
71279d5
@happsie
ISSUE-123, add comment to GetMargins and move mock into basePdfTest
08dfd11
@johnfercher johnfercher merged commit c270f3d into johnfercher:feature/custom-margins Dec 20, 2019
felix pushed a commit to felix/maroto that referenced this pull request May 2, 2022
@johnfercher
Merge pull request johnfercher#127 from Jepzter/feature/add-custom-pa…
cb81462 
…ge-margins

Feature/add custom page margins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnfercher @happsie