release/20-12-2019 #120
Merged
release/20-12-2019 #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix all examples; * Add an item to update examples in template;
* Create GetScalarFactor method in Text interface; * Create GetLinesQuantity method in Text interface; * Extract private method getLines to build lines from words, Text.Add and Text.GetLinesQuantity use this new method; * Remove HeaderHeight property from TableList prop; * Remove ContentHeight property from TableList prop; * Add VerticalPadding in Text prop; * Update mocks * Extract tablelist from pdf * Fix unit tests > Obtain the max number of lines from a column inside the row, multiply this value by the font size and sum the vertical padding;
feature/115-auto-adjust-height
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=========================================
- Coverage 98.31% 94.81% -3.5%
=========================================
Files 8 9 +1
Lines 473 520 +47
=========================================
+ Hits 465 493 +28
- Misses 4 22 +18
- Partials 4 5 +1
Continue to review full report at Codecov.
|
felix
pushed a commit
to felix/maroto
that referenced
this pull request
May 2, 2022
release/20-12-2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs: