-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/115-auto-adjust-height #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix all examples; * Add an item to update examples in template;
Codecov Report
@@ Coverage Diff @@
## dev #116 +/- ##
=========================================
- Coverage 98.31% 94.81% -3.5%
=========================================
Files 8 9 +1
Lines 473 520 +47
=========================================
+ Hits 465 493 +28
- Misses 4 22 +18
- Partials 4 5 +1
Continue to review full report at Codecov.
|
johnferchermeli
force-pushed
the
feature/115-auto-adjust-height
branch
4 times, most recently
from
November 13, 2019 01:59
bc36d77
to
5cf48a3
Compare
johnferchermeli
force-pushed
the
feature/115-auto-adjust-height
branch
3 times, most recently
from
November 17, 2019 03:09
be8b4a3
to
1622cec
Compare
SuddenGunter
requested changes
Nov 19, 2019
johnferchermeli
force-pushed
the
feature/115-auto-adjust-height
branch
from
December 20, 2019 02:33
5e77715
to
d291a5e
Compare
johnferchermeli
force-pushed
the
feature/115-auto-adjust-height
branch
from
December 20, 2019 02:46
fe3fd2d
to
712a6a9
Compare
* Create GetScalarFactor method in Text interface; * Create GetLinesQuantity method in Text interface; * Extract private method getLines to build lines from words, Text.Add and Text.GetLinesQuantity use this new method; * Remove HeaderHeight property from TableList prop; * Remove ContentHeight property from TableList prop; * Add VerticalPadding in Text prop; * Update mocks * Extract tablelist from pdf * Fix unit tests > Obtain the max number of lines from a column inside the row, multiply this value by the font size and sum the vertical padding;
johnferchermeli
force-pushed
the
feature/115-auto-adjust-height
branch
from
December 20, 2019 02:57
b0453bf
to
3741470
Compare
Merged
felix
pushed a commit
to felix/maroto
that referenced
this pull request
May 2, 2022
…adjust-height feature/115-auto-adjust-height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt table list to calculate the header and content height to avoid new line issues, as text extrapolating the cell area.
Fix Examples
Auto adjust height
Related Issue
resolve #115
Checklist
func (s *struct) method() {}
name style.go fmt github.com/johnfercher/maroto/...
to format all files