Adding support to osctrl-cli to look up nodes via osctrl-api

[javuto]

• Adding support in osctrl-cli to look up nodes via osctrl-api, merged in Lookup node by identifier inosctrl-api #657
• Better output when issuing the lookup command

[Copilot]

Pull Request Overview

Adds support for looking up nodes via the osctrl API in the CLI and cleans up related types and handlers.

• Removes the old ApiLookupResponse type and swaps schema references to use OsqueryNode
• Implements a new lookup CLI command and the underlying OsctrlAPI.LookupNode method
• Refactors handler code to return raw OsqueryNode, and standardizes some error messages

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/types/types.go	Deleted unused ApiLookupResponse type
osctrl-api.yaml	Changed lookup response reference to OsqueryNode schema
cmd/cli/node.go	Refactored showNode, added lookupNode using _showNode helper
cmd/cli/main.go	Added lookup command; lowercased backend creation error messages
cmd/cli/api-node.go	Added LookupNode implementation on OsctrlAPI
cmd/api/handlers/utils.go	Removed unused node-to-API conversion helper
cmd/api/handlers/nodes.go	Updated handler to return nodes.OsqueryNode directly

Comments suppressed due to low confidence (5)

cmd/cli/api-node.go:70

• [nitpick] Variable name 'l' is ambiguous (looks like '1'); consider renaming to 'req' or 'lookupReq' for clarity.

l := types.ApiLookupRequest{

cmd/cli/main.go:1704

• [nitpick] Error message casing is inconsistent with other messages; consider standardizing (e.g., start with uppercase or lowercase consistently).

return fmt.Errorf("failed to create backend - %w", err)

cmd/cli/main.go:1709

• [nitpick] Error message casing is inconsistent with other messages; consider standardizing (e.g., start with uppercase or lowercase consistently).

return fmt.Errorf("failed to create backend - %w", err)

cmd/cli/node.go:255

• New lookup functionality is introduced without accompanying unit or integration tests; consider adding tests for lookupNode behavior.

func lookupNode(c *cli.Context) error {

cmd/cli/main.go:1210

• [nitpick] The alias 'f' for the 'lookup' command may be non-intuitive; consider using a more descriptive alias like 'l' or 'id'.

Aliases: []string{"f"},