Conversation
javuto
added
✨ enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new endpoint in osctrl-api that allows looking up nodes by various identifiers and updates the OpenAPI documentation accordingly.
- Added the ApiLookupRequest and ApiLookupResponse types in pkg/types/types.go.
- Updated the osctrl-api YAML to include the new /nodes/lookup POST endpoint.
- Implemented LookupNodeHandler and added a helper to convert node objects to lookup responses.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/types.go | Introduces types for lookup requests and responses |
| osctrl-api.yaml | Adds new documentation for the /nodes/lookup endpoint |
| cmd/api/main.go | Registers the new lookup route in the API |
| cmd/api/handlers/utils.go | Adds helper for converting nodes into lookup response format |
| cmd/api/handlers/nodes.go | Implements the LookupNodeHandler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new endpoint in
osctrl-apito look up nodes by identifier (UUID, hostname or localname). Also updating the OpenAPI YAML to keep documentation up to date.