Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test harness diagnostics #17

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Improve test harness diagnostics #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
930a59d
Improve spec test harness for debugging
takikawa Oct 10, 2024
0da47db
Update spec test submodule
takikawa Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source-map-tests
Open in desktop
Submodule source-map-tests updated 18 files
+3 −3 chrome/0001-Add-source-map-specification-tests.patch
+1 −1 resources/ignore-list-wrong-type-4.js
+1 −1 resources/invalid-mapping-segment-with-three-fields.js
+1 −1 resources/invalid-mapping-segment-with-two-fields.js
+1 −1 resources/invalid-mapping-segment-with-zero-fields.js
+1 −0 resources/mappings-missing.js
+6 −0 resources/mappings-missing.js.map
+1 −1 resources/source-root-not-a-string-2.js
+1 −0 resources/sources-content-missing.js
+6 −0 resources/sources-content-missing.js.map
+1 −0 resources/sources-content-not-a-list-1.js
+7 −0 resources/sources-content-not-a-list-1.js.map
+1 −0 resources/sources-content-not-a-list-2.js
+7 −0 resources/sources-content-not-a-list-2.js.map
+1 −0 resources/sources-content-not-string-or-null.js
+7 −0 resources/sources-content-not-string-or-null.js.map
+35 −0 source-map-spec-tests.json
+12 −12 webkit/0001-Add-test-runner-for-the-source-map-spec-tests.patch
12 changes: 7 additions & 5 deletions src/spec-tests.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url));
const specResourcesBaseDir = path.resolve(__dirname, "../../source-map-tests/resources");

// These tests are known failures that aren't easily fixed at the moment.
const skippedTests = [
const knownFailures = [
// Source maps library does not consider this a parse error.
"invalidMappingSegmentWithZeroFields",
// Source maps library ignores the sign bit in the size limit.
Expand All @@ -24,9 +24,8 @@ const skippedTests = [
test.describe("runSourceMapSpecTests", () => {
sourceMapSpecTests.tests.forEach((testCase) => {
test(`The source map spec test case "${testCase.name}" has ${testCase.sourceMapIsValid ? "a valid" : "an invalid"} source map`, async (t) => {
if (skippedTests.includes(testCase.name)) {
t.skip();
return;
if (knownFailures.includes(testCase.name)) {
t.todo("This test has a known failure and doesn't fail the test suite");
}
const result = await validateSourceMap([
"--sourceMap",
Expand All @@ -38,8 +37,11 @@ test.describe("runSourceMapSpecTests", () => {
]);
if (testCase.sourceMapIsValid)
assert.deepEqual(result, { isValid: true }, "expected source map to be valid");
else
else {
assert.equal(result.isValid, false, "expected source map to be invalid");
if (!result.isValid && result.errors[0])
t.diagnostic(result.errors[0].message);
}
});
});
});
Loading