Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves debugging with the spec tests. For invalid source maps it prints the failure reason so it's much easier to check if maps are rejected for the right reason.
For known failures, use
todo
to make it easier to track why it's failing.Also update the spec test submod.
Note: in most cases, invalid maps are being rejected for the right reason thankfully. But in some cases the test cases need tweaking to avoid the wrong exception (there's a fairly trivial issue related to source handling) and there are a few cases where the upstream source-map library is not error-checking where it should. I'll make separate PRs related to these.