Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: update responses #11

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature: update responses #11

wants to merge 3 commits into from

Conversation

jfkz
Copy link
Owner

@jfkz jfkz commented Feb 2, 2025

Breaking change:

  1. According to GetCardListResponsePayload probably has incorrect type #9 there is different types of Tinkoff API responses so I decided to change structures to support all of them
  2. This can cause issues related to strong typization so it need to be tested first.

Additional step for this PR:

  1. Add unit tests.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jfkz