-
Notifications
You must be signed in to change notification settings - Fork 1.9k
#7091 support socks5 #9653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
huisongma
wants to merge
11
commits into
jetty:jetty-10.0.x
from
huisongma:jetty-10.0.x-socks5-support
Closed
#7091 support socks5 #9653
huisongma
wants to merge
11
commits into
jetty:jetty-10.0.x
from
huisongma:jetty-10.0.x-socks5-support
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code format
code format
code format
1.add Authorization interface 2.add NoAuthorization and UsernamePasswodAuthorization implements
change code style
change code style
change code style
#9633 blocked by eclipse ECA, so I created a new pull request |
Closed
change code style
Is this request can be merge? @sbordet |
sbordet
added a commit
that referenced
this pull request
May 3, 2023
Spin-off of the work in #9653. Simplified the implementation, fixed a few mistakes, added more tests. Made the implementation of Socks5.Authentication more extensible (for example to implement GSSAPI authentication). Updated documentation. Signed-off-by: Simone Bordet <[email protected]>
@huisongma I have taken your work, simplified and improved it, added more tests and documentation. Please add your review to #9727. Thanks for your contribution! |
olamy
pushed a commit
that referenced
this pull request
May 5, 2023
Spin-off of the work in #9653. Simplified the implementation, fixed a few mistakes, added more tests. Made the implementation of Socks5.Authentication more extensible (for example to implement GSSAPI authentication). Updated documentation. Signed-off-by: Simone Bordet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7091 support socks5 proxy