Skip to content

#7091 support socks5 #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

huisongma
Copy link
Contributor

#7091 support socks5 proxy

1.add Authorization interface
2.add NoAuthorization and UsernamePasswodAuthorization implements
change code style
change code style
change code style
@huisongma
Copy link
Contributor Author

#9633 blocked by eclipse ECA, so I created a new pull request

@huisongma huisongma mentioned this pull request Apr 15, 2023
change code style
@huisongma
Copy link
Contributor Author

Is this request can be merge? @sbordet

sbordet added a commit that referenced this pull request May 3, 2023
Spin-off of the work in #9653.
Simplified the implementation, fixed a few mistakes, added more tests.
Made the implementation of Socks5.Authentication more extensible (for example to implement GSSAPI authentication).
Updated documentation.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet
Copy link
Contributor

sbordet commented May 3, 2023

@huisongma I have taken your work, simplified and improved it, added more tests and documentation.
I have retained your authorship but squashed your commits, so your contribution is not lost.

Please add your review to #9727.

Thanks for your contribution!

@sbordet sbordet closed this May 3, 2023
olamy pushed a commit that referenced this pull request May 5, 2023
Spin-off of the work in #9653.
Simplified the implementation, fixed a few mistakes, added more tests.
Made the implementation of Socks5.Authentication more extensible (for example to implement GSSAPI authentication).
Updated documentation.

Signed-off-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants