Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SOCKS5 support #7091

Closed
michedsa opened this issue Nov 9, 2021 · 2 comments · Fixed by #9727
Closed

Add SOCKS5 support #7091

michedsa opened this issue Nov 9, 2021 · 2 comments · Fixed by #9727
Labels
Enhancement

Comments

@michedsa
Copy link

michedsa commented Nov 9, 2021

Target Jetty version(s)
We are currently using the jetty websocket 10 using SOCKS4 proxy.
Enhancement Description
We need to support in the feature websocket via SOCKS5 proxy.
Would it be possible to have the SOCKS5 version in the next release of jetty?
@joakime joakime changed the title SOCKS5 support Add SOCKS5 support Nov 9, 2021
@joakime
Copy link
Contributor

joakime commented Nov 9, 2021

The spec for SOCKS5 can be found at https://datatracker.ietf.org/doc/html/rfc1928

This would be a low priority for us at the moment, as we are focused on HTTP/3 and Jetty 12 with Servlet 6.

We'll happily take a PR to add SOCKS5 support to Jetty 10.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Nov 10, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Nov 10, 2022
huisongma added a commit to huisongma/jetty.project that referenced this issue Apr 11, 2023
@huisongma
jetty#7091 support socks5
49051f4
@huisongma huisongma mentioned this issue Apr 15, 2023
Closed
sbordet pushed a commit that referenced this issue May 3, 2023
@huisongma @sbordet
Initial implementation for #7091 - SOCKS5 support.
28cd6d8
sbordet added a commit that referenced this issue May 3, 2023
@sbordet
Fixes #7091 - Add SOCKS5 support.
d4e9f6a 
Spin-off of the work in #9653.
Simplified the implementation, fixed a few mistakes, added more tests.
Made the implementation of Socks5.Authentication more extensible (for example to implement GSSAPI authentication).
Updated documentation.

Signed-off-by: Simone Bordet <[email protected]>
@gregw gregw mentioned this issue May 4, 2023
Merged
sbordet added a commit that referenced this issue May 4, 2023
@sbordet
Merge pull request #9727 from eclipse/fix/jetty-10-7091-socks5
d5f68a7 
Fixes #7091 - Add SOCKS5 support
olamy pushed a commit that referenced this issue May 5, 2023
@huisongma @olamy
Initial implementation for #7091 - SOCKS5 support.
2d4eacb
olamy pushed a commit that referenced this issue May 5, 2023
@sbordet @olamy
Fixes #7091 - Add SOCKS5 support.
843b96c 
Spin-off of the work in #9653.
Simplified the implementation, fixed a few mistakes, added more tests.
Made the implementation of Socks5.Authentication more extensible (for example to implement GSSAPI authentication).
Updated documentation.

Signed-off-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #7091 - Add SOCKS5 support jetty/jetty.project
3 participants
@joakime @sbordet @michedsa