Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup of websocket to fix JPMS warnings #9356

Merged
merged 10 commits into from
Feb 17, 2023
Merged

cleanup of websocket to fix JPMS warnings #9356

merged 10 commits into from
Feb 17, 2023

Conversation

lachlan-roberts
Copy link
Contributor

remove the "export to" lines from websocket internal packages
move some classes out of the internal packages so they are now visible

@sbordet
Copy link
Contributor

sbordet commented Feb 15, 2023

@lachlan-roberts also, jetty-websocket-core-client has this warning:

[INFO] --- maven-bundle-plugin:5.1.8:manifest (default) @ jetty-websocket-core-client ---
[INFO] No MANIFEST.MF file found, generating manifest.
[WARNING] Manifest org.eclipse.jetty.websocket:jetty-websocket-core-client:jar:12.0.0-SNAPSHOT : Unused Export-Package instructions: [org.eclipse.jetty.websocket.core.client.internal.*] 
[INFO] Writing manifest: /home/simon/opensource/jetty/12.0/jetty-core/jetty-websocket/jetty-websocket-core-client/target/classes/META-INF/MANIFEST.MF

Something related to #9327?

@gregw
Copy link
Contributor

gregw commented Feb 15, 2023

this PR should also remove the work around from the OSGI manifest.

@janbartel
Copy link
Contributor

OSGi workaround lines to remove:

./jetty-websocket-core-common/pom.xml: ,org.eclipse.jetty.websocket.core.common.internal.
./jetty-websocket-core-client/pom.xml: ,org.eclipse.jetty.websocket.core.client.internal.

@gregw gregw mentioned this pull request Feb 16, 2023
Closed
@lachlan-roberts lachlan-roberts merged commit 8104665 into jetty-12.0.x Feb 17, 2023
@lachlan-roberts lachlan-roberts deleted the jetty-12.0.x-websocket-JPMS branch February 17, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet requested changes

@gregw gregw Awaiting requested review from gregw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lachlan-roberts @sbordet @gregw @janbartel