Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 12 - Review POMs to remove OSGi directives for internal packages #9327

Closed
sbordet opened this issue Feb 7, 2023 · 4 comments
Closed
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@sbordet
Copy link
Contributor

sbordet commented Feb 7, 2023

Jetty version(s)
12+

Description
There used to be special directives for OSGi in the POMs to include internal packages.
This was necessary because module-info.java had export ... to ... directives, but these are now gone with the work of #9293.

What's left in the POMs for OSGi, if anything, should be removed.

@sbordet sbordet added the Bug For general bugs on Jetty side label Feb 7, 2023
@janbartel
Copy link
Contributor

There are some packages that are still called internal that are being used outside of the jar in which it is declared. For example:

Trying to start the bundle org.eclipse.jetty.websocket.core.server that was supposed to be active or resolved.
org.eclipse.jetty.websocket.core.server failed to start
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.jetty.websocket.core.server [69]
Unresolved requirement: Import-Package: org.eclipse.jetty.websocket.core.internal

@lachlan-roberts
Copy link
Contributor

As part of #9233 I will remove any export of internal packages from websocket. At that point the OSGi directives can be removed.

@gregw
Copy link
Contributor

gregw commented Feb 16, 2023

This should be fixed by #9356

@lachlan-roberts
Copy link
Contributor

I looked at all the <Export-Package> tags in the poms and there are no other ones that export internal packages. So I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

No branches or pull requests

4 participants