Jetty 12 - Add tests in util/resource for alternate FileSystem implementations #9149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorban
requested changes
Jan 10, 2023
...-core/jetty-util/src/main/java/org/eclipse/jetty/util/resource/ResourceFactoryInternals.java
Show resolved
Hide resolved
...etty-util/src/test/java/org/eclipse/jetty/util/resource/AlternateFileSystemResourceTest.java
Outdated
Show resolved
Hide resolved
| URL url = ResourceFactoryInternals.class.getResource("/org/eclipse/jetty/version/build.properties"); | ||
| if ((url != null) && !RESOURCE_FACTORIES.contains(url.getProtocol())) | ||
| { | ||
| RESOURCE_FACTORIES.put(url.getProtocol(), mountedPathResourceFactory); |
There was a problem hiding this comment.
Why not using a new MountedPathResourceFactory instance?
There was a problem hiding this comment.
No real reason to, the implementation wouldn't change with each new protocol.
There was a problem hiding this comment.
An argument could be made that there should be a test here, to see if the URL points to a mounted FileSystem or not, and adding the appropriate ResourceFactory based on results.
Or using some variation of the mountIfNeeded() logic always here?
There was a problem hiding this comment.
If adding some logic to figure out if mounting is needed or not doesn't take too much, let's add it. Otherwise let's get these changes make it in and eventually open an enhancement bug.
...etty-util/src/test/java/org/eclipse/jetty/util/resource/AlternateFileSystemResourceTest.java
Show resolved
Hide resolved
lorban
approved these changes
Jan 11, 2023
gregpoulos
pushed a commit
to gregpoulos/jetty.project
that referenced
this pull request
Jan 16, 2023
…x-document-modules * upstream/jetty-12.0.x: Issue jetty#9167 - making assumption in flaky test jetty 12.0.x cleanup duplicate osgi pom metadata (jetty#9093) Jetty 12 - Add tests in util/resource for alternate FileSystem implementations (jetty#9149) Cleanup non-retainable `Retainable`s (jetty#9159) Fixes retainability of special Chunks (jetty#9073) TCK: Dispatch forward and includes attributes do not meet the spec (jetty#9074) re-enable h3 tests (jetty#8773) More fundamental test case Reorganization of jetty-client classes. (jetty#9127) Removing @disabled from SslUploadTest Removing @disabled from jetty-start jetty#9134 added test ee10: DefaultServlet: Replace checks for isStreaming() by !isWriting() jetty#9078 make HttpContent.getByteBuffer() implementations return new ByteBuffer instances and document that contract Fixes jetty#9141 - Thread-safe Content.Chunk#slice (jetty#9142) Remove `@Disabled` from `jetty-jmx` (jetty#9143) Bump maven.version from 3.8.6 to 3.8.7 Bump maven.version from 3.8.6 to 3.8.7
gregpoulos
pushed a commit
to gregpoulos/jetty.project
that referenced
this pull request
Jan 16, 2023
… into jetty-12.0.x-documentation-lowercase-jetty_home-attribute * 'jetty-12.0.x' of https://github.com/eclipse/jetty.project: Issue jetty#9167 - making assumption in flaky test jetty 12.0.x cleanup duplicate osgi pom metadata (jetty#9093) Jetty 12 - Add tests in util/resource for alternate FileSystem implementations (jetty#9149) Cleanup non-retainable `Retainable`s (jetty#9159) Fixes retainability of special Chunks (jetty#9073) TCK: Dispatch forward and includes attributes do not meet the spec (jetty#9074) re-enable h3 tests (jetty#8773) More fundamental test case Reorganization of jetty-client classes. (jetty#9127) Removing @disabled from SslUploadTest Removing @disabled from jetty-start Bump maven.version from 3.8.6 to 3.8.7 Bump maven.version from 3.8.6 to 3.8.7
joakime
deleted the
fix/jetty-12.0.x/support-alternate-filesytem-mounts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some jetty-util Resource tests for alternate FileSystem providers, to ensure that we are not doing anything awkward in our implementation that would prevent it.
This uses the https://github.com/google/jimfs implementation of an In-Memory FileSystem implementation to accomplish these tests.
(This filesystem uses scheme
jimfsand has a URI authority representing the named FileSystem)This was initiated as a response to a question about our support for alternate FileSystem implementations in PR #9136