Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetty 12.0.x cleanup duplicate osgi pom metadata #9093

Merged
merged 4 commits into from
Jan 16, 2023
Merged

jetty 12.0.x cleanup duplicate osgi pom metadata #9093

merged 4 commits into from
Jan 16, 2023

Conversation

olamy
Copy link
Member

@olamy olamy commented Dec 27, 2022

  • fix naming convention, artifactId == directtory, add comment on maven-eclipse-plugin
  • cleanup dependencies from jetty-ee9 osgi
  • cleanup dependencies from jetty-ee10 osgi

@olamy olamy added the Build label Dec 27, 2022
olamy
olamy commented Dec 27, 2022
View reviewed changes
jetty-ee10/jetty-ee10-osgi/pom.xml Outdated
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-eclipse-plugin</artifactId>
<version>2.9</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janbartel do you really use this plugin?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janbartel ping? maybe we can remove those lines?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olamy nope, I don't use that plugin at all, so go ahead and remove.

@olamy olamy force-pushed the jetty-12.0.x-cleanup-duplicate-osgi-pom-metadata branch 2 times, most recently from ea132b0 to 0b98861 Compare December 29, 2022 07:43
@joakime joakime added this to the 12.0.x milestone Jan 2, 2023
@olamy olamy force-pushed the jetty-12.0.x-cleanup-duplicate-osgi-pom-metadata branch from 12b4f9d to 1fab82f Compare January 12, 2023 02:08
@olamy olamy merged commit 58f5e46 into jetty-12.0.x Jan 16, 2023
@olamy olamy deleted the jetty-12.0.x-cleanup-duplicate-osgi-pom-metadata branch January 16, 2023 01:39
gregpoulos pushed a commit to gregpoulos/jetty.project that referenced this pull request Jan 16, 2023
Merge remote-tracking branch 'upstream/jetty-12.0.x' into jetty-12.0.…
f4e2fa7 
…x-document-modules

* upstream/jetty-12.0.x:
  Issue jetty#9167 - making assumption in flaky test
  jetty 12.0.x cleanup duplicate osgi pom metadata (jetty#9093)
  Jetty 12 - Add tests in util/resource for alternate FileSystem implementations (jetty#9149)
  Cleanup non-retainable `Retainable`s (jetty#9159)
  Fixes retainability of special Chunks (jetty#9073)
  TCK: Dispatch forward and includes attributes do not meet the spec (jetty#9074)
  re-enable h3 tests (jetty#8773)
  More fundamental test case
  Reorganization of jetty-client classes. (jetty#9127)
  Removing @disabled from SslUploadTest
  Removing @disabled from jetty-start
  jetty#9134 added test
  ee10: DefaultServlet: Replace checks for isStreaming() by !isWriting()
  jetty#9078 make HttpContent.getByteBuffer() implementations return new ByteBuffer instances and document that contract
  Fixes jetty#9141 - Thread-safe Content.Chunk#slice (jetty#9142)
  Remove `@Disabled` from `jetty-jmx` (jetty#9143)
  Bump maven.version from 3.8.6 to 3.8.7
  Bump maven.version from 3.8.6 to 3.8.7
gregpoulos pushed a commit to gregpoulos/jetty.project that referenced this pull request Jan 16, 2023
Merge branch 'jetty-12.0.x' of https://github.com/eclipse/jetty.project…
4b5c40d 
… into jetty-12.0.x-documentation-lowercase-jetty_home-attribute

* 'jetty-12.0.x' of https://github.com/eclipse/jetty.project:
  Issue jetty#9167 - making assumption in flaky test
  jetty 12.0.x cleanup duplicate osgi pom metadata (jetty#9093)
  Jetty 12 - Add tests in util/resource for alternate FileSystem implementations (jetty#9149)
  Cleanup non-retainable `Retainable`s (jetty#9159)
  Fixes retainability of special Chunks (jetty#9073)
  TCK: Dispatch forward and includes attributes do not meet the spec (jetty#9074)
  re-enable h3 tests (jetty#8773)
  More fundamental test case
  Reorganization of jetty-client classes. (jetty#9127)
  Removing @disabled from SslUploadTest
  Removing @disabled from jetty-start
  Bump maven.version from 3.8.6 to 3.8.7
  Bump maven.version from 3.8.6 to 3.8.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janbartel janbartel janbartel approved these changes

@joakime joakime joakime approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
12.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@olamy @joakime @janbartel