-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for conditional module dependencies in jetty-start #4628
Comments
See #4443 for ALPN support in 8u252 without |
would it make more sense to have this be a different section?
I don't know a good name for this section as Some alternate thoughts on names ...
|
Signed-off-by: Joakim Erdfelt <[email protected]>
Issue #4628 - Non-Required Module Dependency Support
Merged PR #4629 |
Signed-off-by: Joakim Erdfelt <[email protected]>
@sbordet How is this different from the existing |
@sbordet has explained the difference to [optional]. An optional dependency is just ordered but not enabled - it has to be explicitly enabled by something else. Thus my issue with this is the name - I think the naming can be fixed up in #4633 |
…y-start. Updated after review. Renamed isRequiredModule() -> isConditionalModule() and inverted expressions that were using the method. Signed-off-by: Simone Bordet <[email protected]>
…on-required Issue #4628 - Ensuring checkEnabledModules is conditional dependency aware
Fixed with #4633. |
Description
The jetty-start module mechanism could benefit from having
[depends]
on modules that may or may-not actually be present.This would simplify behaviors like the ones identified (by @sbordet) with alpn and Java 8 update 252 and newer having built-in support for ALPN (no longer any need for alpn-boot).
Proposed syntax:
That would mean if the
alpn-boot/alpn-boot-${java.version}
module file doesn't exist, then it's a quietly skipped.(This skipped module is still logged using StartLog's DEBUG level)
This syntax uses the
"?"
character to indicate an optional behavior similar to how it's used with the property syntax<name>?=<value>
today.However, the character
"?"
is a valid character on the filesystem. (Does this matter to us?)The text was updated successfully, but these errors were encountered: