Issue #4628 - Ensuring checkEnabledModules is required dependency aware

Signed-off-by: Joakim Erdfelt <[email protected]>
jetty · Mar 3, 2020 · dbaf0bf · dbaf0bf
1 parent f150062
commit dbaf0bf
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 10 deletions.
diff --git a/jetty-start/src/main/java/org/eclipse/jetty/start/Modules.java b/jetty-start/src/main/java/org/eclipse/jetty/start/Modules.java
@@ -487,17 +487,19 @@ public void checkEnabledModules()
         _modules.stream().filter(Module::isEnabled).forEach(m ->
         {
             // Check dependencies
-            m.getDepends().forEach(d ->
-            {
-                Set<Module> providers = getAvailableProviders(d);
-                if (providers.stream().filter(Module::isEnabled).count() == 0)
+            m.getDepends().stream()
+                .filter(Module::isRequiredDependency)
+                .forEach(d ->
                 {
-                    if (unsatisfied.length() > 0)
-                        unsatisfied.append(',');
-                    unsatisfied.append(m.getName());
-                    StartLog.error("Module %s requires a module providing %s from one of %s%n", m.getName(), d, providers);
-                }
-            });
+                    Set<Module> providers = getAvailableProviders(d);
+                    if (providers.stream().noneMatch(Module::isEnabled))
+                    {
+                        if (unsatisfied.length() > 0)
+                            unsatisfied.append(',');
+                        unsatisfied.append(m.getName());
+                        StartLog.error("Module %s requires a module providing %s from one of %s%n", m.getName(), d, providers);
+                    }
+                });
         });
 
         if (unsatisfied.length() > 0)

diff --git a/jetty-start/src/test/java/org/eclipse/jetty/start/ModulesTest.java b/jetty-start/src/test/java/org/eclipse/jetty/start/ModulesTest.java
@@ -234,6 +234,7 @@ public void testResolveNotRequiredModuleNotFound() throws IOException
 
         // Collect active module list
         List<Module> active = modules.getEnabled();
+        modules.checkEnabledModules();
 
         // Assert names are correct, and in the right order
         List<String> expectedNames = new ArrayList<>();
@@ -282,6 +283,7 @@ public void testResolveNotRequiredModuleFound() throws IOException
 
         // Collect active module list
         List<Module> active = modules.getEnabled();
+        modules.checkEnabledModules();
 
         // Assert names are correct, and in the right order
         List<String> expectedNames = new ArrayList<>();
@@ -331,6 +333,7 @@ public void testResolveNotRequiredModuleFoundDynamic() throws IOException
 
         // Collect active module list
         List<Module> active = modules.getEnabled();
+        modules.checkEnabledModules();
 
         // Assert names are correct, and in the right order
         List<String> expectedNames = new ArrayList<>();