Conversation
Due to cert-manager 1.5 being released Signed-off-by: irbekrm <irbekrm@gmail.com>
|
/release-note-none |
wallrj
left a comment
There was a problem hiding this comment.
There was a bit more to the PR last you did this: https://github.com/jetstack/testing/pull/515/files
but I think that was because we also added K8S 1.21 testing at the same time.
/approve
/lgtm
There was a problem hiding this comment.
Do we want to add 1.22 testing for all PRs against master in this change too? I think it'd be valuable; feel free to unhold if we should do that in a different PR! (EDIT: or if we don't want to do that 😁 )
(If we don't change it here, we'll need to change the supported releases page, which I'll keep an eye on)
/hold
I wanted to get cert-manager/cert-manager#4341 merged first |
Also adds an e2e test against Kubernetes v1.22 to release-next periodics and bump the version of Kubernetes for upgrade tests and tests that focus on Venafi TPP/Venafi Cloud to v1.22 Signed-off-by: irbekrm <irbekrm@gmail.com>
Thanks @SgtCoDFish I've updated PR. |
SgtCoDFish
left a comment
There was a problem hiding this comment.
/lgtm
I think there'd be some value to us running both v1.21 and v1.22 e2e tests on every PR, but I don't think it's required and given the flakiness we've seen from our tests, it might well do more harm than good to test against 2 versions every time 😅
After this is merged, I'll update this page to reflect exactly which versions we test against.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, SgtCoDFish, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yeah I was thinking about that too. Not strongly convinced either way, but we are also resource limited for test nodes 😿 Maybe I will just unhold this, running both if we decide so would be just a matter of changing two lines, shout if you disagree /hold cancel |
|
FWIW I don't understand why the PRs against this repo don't get automatically merged. |
|
Seems like some unhappiness in Tide: I see that a similar issue has been fixed a while ago (and we are running a tide version with that fix). Perhaps something to keep in mind and investigate in case PR merging breaks for cert-manager as well. |
|
@irbekrm: Updated the following 3 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this follows cert-manager/testing#553 being merged Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
This PR:
Signed-off-by: irbekrm irbekrm@gmail.com