Sort pending contexts when displaying them from tide#15300
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Nov 17, 2019
Merged
Sort pending contexts when displaying them from tide#15300k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/prow
Member
|
/lgtm Holding to give others time to see this. |
k8s-ci-robot
added
do-not-merge/hold
stevekuznetsov
force-pushed
the
skuznets/tide-status-improvement
branch
from
c31ad8d to
72ea370
Compare
k8s-ci-robot
removed
the
lgtm
When a list of contexts is presented as pending from the tide status controller, we need to sort the contexts in the list so that we do not attempt to update the message with a different but equivalent permutation of the pending contexts on every sync loop. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
stevekuznetsov
force-pushed
the
skuznets/tide-status-improvement
branch
from
72ea370 to
b7dd3d1
Compare
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clarketm, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a list of contexts is presented as pending from the tide status
controller, we need to sort the contexts in the list so that we do not
attempt to update the message with a different but equivalent
permutation of the pending contexts on every sync loop.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
fixes #15299
/assign @alvaroaleman @cjwagner