-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore: remove lint exceptions for files in examples folder
#13346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import {Component} from '@angular/core'; | ||
|
|
||
| import {DataService} from './shared/data.service'; | ||
|
|
||
| @Component({ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| import {Injectable} from '@angular/core'; | ||
|
|
||
| import {SubService} from './sub.service'; | ||
|
|
||
| @Injectable() | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,6 @@ | ||
| // mongo-environment.js | ||
| const NodeEnvironment = require('jest-environment-node').default; | ||
|
|
||
| const path = require('path'); | ||
|
|
||
| const fs = require('fs'); | ||
| import fs from 'fs'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this should be ESM?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It probably doesn't hurt, tho
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was hard to look at
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nah, it's fine. Sorta surprised it works tho - the |
||
| import path from 'path'; | ||
| import NodeEnvironment from 'jest-environment-node'; | ||
|
|
||
| const globalConfigPath = path.join(__dirname, 'globalConfig.json'); | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without turning this off ESLint is pushing to use
graceful-fs.