chore: remove lint exceptions for files in examples folder
#13346
Conversation
| rules: { | ||
| 'import/no-unresolved': ['error', {ignore: ['^react-native$']}], | ||
| 'import/order': 'off', | ||
| 'no-restricted-imports': 'off', |
There was a problem hiding this comment.
Without turning this off ESLint is pushing to use graceful-fs.
| const path = require('path'); | ||
|
|
||
| const fs = require('fs'); | ||
| import fs from 'fs'; |
There was a problem hiding this comment.
I don't think this should be ESM?
There was a problem hiding this comment.
It was hard to look at require('jest-environment-node').default above. That’s the only reason. I can revert.
There was a problem hiding this comment.
Nah, it's fine. Sorta surprised it works tho - the default in CJS is different from native ESM default. Can use const {TestEnvironment} = require('jest-environment-jsdom')
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
From #13345 (comment)
Summary
Strangely ESLint rule
'import/order'is set to'off'for theexamplesfolder. I double checked if that is somehow needed to keep the examples and docs in sync. Can’t find any reason. I think same lint rule can be applied for examples as well as code base.Test plan
Green CI.