Async admonitions. #12495 #13305
Closed
Async admonitions. #12495 #13305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
reviewed
Sep 22, 2022
| @@ -115,7 +115,11 @@ If `done()` is never called, the test will fail (with timeout error), which is w | |||
|
|
|||
| If the `expect` statement fails, it throws an error and `done()` is not called. If we want to see in the test log why it failed, we have to wrap `expect` in a `try` block and pass the error in the `catch` block to `done`. Otherwise, we end up with an opaque timeout error that doesn't show what value was received by `expect(data)`. | |||
|
|
|||
| _Note: `done()` should not be mixed with Promises as this tends to lead to memory leaks in your tests._ | |||
| :::note | |||
There was a problem hiding this comment.
See #13284. Edit: fine to close this PR which I use as an example, but yours must be identical.
|
Since I started this in June I unintentionally duplicated your PR. Should I close this one too? @mrazauskas |
|
#13284 got merged yesterday. All is fixed in the page. So this PR can be closed now. Thanks for sending it in anyways. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan