docs: use admonition in Testing Asynchronous Code page #13284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Sep 20, 2022
| _Note: `done()` should not be mixed with Promises as this tends to lead to memory leaks in your tests._ | ||
| :::caution | ||
|
|
||
| `done()` should not be mixed with promises as this tends to lead to memory leaks in your tests. |
There was a problem hiding this comment.
This is a runtime error now I think. Might make sense to mention? #10512
There was a problem hiding this comment.
Good idea. I double checked, runtime error is there since v27. So the note is tweak from v27 and up.
mrazauskas
commented
Sep 20, 2022
|
@SimenB This one is good now? Or? (; |
This was referenced Sep 22, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing admonition in Testing Asynchronous Code page. Tiny change, so I have done all versions in one go.
Test plan
Deploy preview.