test(rfc0024): red — all seven §5 stubs land, status drafted→red

[jensholdgaard]

The #353 red-stub pattern for RFC 0024: seven #[ignore]d todo!() stubs placed with the crates that own each invariant — .1/.2/.7 (calibration + the adversarial umbrella) in ourios-bench, .3 (P1 round-trip) in ourios-parquet, .4/.5 (P2/P3) in ourios-miner, .6 (P4 query oracle) in ourios-querier — each naming its green slice.

Also settles the RFC's §7.2 open question in §3.2: generators live in a new dev-only crates/ourios-testgen (hosting them in ourios-bench would create a dev-dependency cycle through ourios-querier), named by the RFC per the CLAUDE.md §7 new-crate rule. Status rides drafted → red on the maintainer's drive-the-RFC go. Default cargo test stays green.

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 14 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5bf4fb09-8be0-4945-beee-7b40e79a25fe

📥 Commits

Reviewing files that changed from the base of the PR and between 6870d29 and 47ea171.

📒 Files selected for processing (5)

• crates/ourios-bench/tests/rfc0024_calibration.rs
• crates/ourios-miner/tests/rfc0024_properties.rs
• crates/ourios-parquet/tests/rfc0024_properties.rs
• crates/ourios-querier/tests/rfc0024_properties.rs
• docs/rfcs/0024-otlp-envelope-property-testing.md

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch rfc0024-red

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Pull request overview

This PR advances RFC 0024 to the “red” gate by landing ignored todo!() test stubs for each §5 acceptance criterion and updating the RFC text to reflect the intended generator strategy/module placement.

Changes:

• Update RFC 0024 status from drafted → red, and revise the generator-home decision text.
• Add ignored red-gate stub tests for RFC0024.1–.7, distributed across the owning crates (ourios-bench, ourios-parquet, ourios-miner, ourios-querier).
• Add a calibration/adversarial “scenario placement map” test module in ourios-bench.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
docs/rfcs/0024-otlp-envelope-property-testing.md	Marks RFC as red and updates generator-home narrative in §3.2 / open-questions list.
crates/ourios-bench/tests/rfc0024_calibration.rs	Adds ignored stubs for calibration (.1/.2) and adversarial umbrella (.7), plus scenario ownership mapping.
crates/ourios-parquet/tests/rfc0024_properties.rs	Adds ignored stub for P1 round-trip fidelity (.3).
crates/ourios-miner/tests/rfc0024_properties.rs	Adds ignored stubs for P2 no-silent-merge (.4) and P3 bounds (.5).
crates/ourios-querier/tests/rfc0024_properties.rs	Adds ignored stub for P4 query-oracle property (.6).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.