test(rfc0022): red — all seven §5 stubs land - #344
Conversation
Writer-side .1/.2 in ourios-parquet, query-side .3–.7 in ourios-querier; each stub is #[ignore]d (default run stays green) and names the green slice that discharges it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 34 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Moves RFC 0022 into the Red gate by flipping its frontmatter status to red and landing the corresponding ignored, compiling-but-failing acceptance-test stubs for all seven §5 scenarios (writer-side in ourios-parquet, query-side in ourios-querier).
Changes:
- Update RFC 0022 frontmatter status from
specified→red. - Add
#[ignore]d integration-test stubs for RFC0022.1–.2 (writer projection/encodings) inourios-parquet. - Add
#[ignore]d integration-test stubs for RFC0022.3–.7 (query parity, operator gating, pruning, read-path blindness, drift) inourios-querier.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/rfcs/0022-queryable-attribute-columns.md | Flip RFC status to red to reflect entry into the red-test/stub phase. |
| crates/ourios-querier/tests/rfc0022_attr_columns.rs | Add ignored red stubs for query-side RFC 0022 §5 scenarios (.3–.7). |
| crates/ourios-parquet/tests/rfc0022_promoted_columns.rs | Add ignored red stubs for writer-side RFC 0022 §5 scenarios (.1–.2). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What
RFC 0022 →
red(maintainer design sign-off received on #343'sspecifieddoc). All seven §5 scenario stubs land,#[ignore]d per the house red convention (defaultcargo teststays green; each stub names its green slice):crates/ourios-parquet/tests/rfc0022_promoted_columns.rs— RFC0022.1 (implicitservice.nameprojection) / .2 (configured keys + encodings)crates/ourios-querier/tests/rfc0022_attr_columns.rs— RFC0022.3 (old-file parity) / .4 (operator gating) / .5 (pruning via RFC 0016 counters) / .6 (projection-blind read path) / .7 (promoted-set drift)Green slices follow in dependency order: writer projection (.1/.2) → predicate compile (.3/.4/.6) → config extension + pruning (.5/.7).
No code paths change; docs delta is the status flip.
🤖 Generated with Claude Code