Skip to content

test(rfc0022): red — all seven §5 stubs land - #344

Merged
jensholdgaard merged 1 commit into
mainfrom
rfc0022-red
Jul 3, 2026
Merged

test(rfc0022): red — all seven §5 stubs land#344
jensholdgaard merged 1 commit into
mainfrom
rfc0022-red

Conversation

@jensholdgaard

Copy link
Copy Markdown
Owner

What

RFC 0022 → red (maintainer design sign-off received on #343's specified doc). All seven §5 scenario stubs land, #[ignore]d per the house red convention (default cargo test stays green; each stub names its green slice):

  • crates/ourios-parquet/tests/rfc0022_promoted_columns.rs — RFC0022.1 (implicit service.name projection) / .2 (configured keys + encodings)
  • crates/ourios-querier/tests/rfc0022_attr_columns.rs — RFC0022.3 (old-file parity) / .4 (operator gating) / .5 (pruning via RFC 0016 counters) / .6 (projection-blind read path) / .7 (promoted-set drift)

Green slices follow in dependency order: writer projection (.1/.2) → predicate compile (.3/.4/.6) → config extension + pruning (.5/.7).

No code paths change; docs delta is the status flip.

🤖 Generated with Claude Code

Writer-side .1/.2 in ourios-parquet, query-side .3–.7 in
ourios-querier; each stub is #[ignore]d (default run stays green) and
names the green slice that discharges it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jensholdgaard, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5715d1b1-40a6-4ed5-96af-bd550da86f5a

📥 Commits

Reviewing files that changed from the base of the PR and between 2f22c96 and 7a871e6.

📒 Files selected for processing (3)
  • crates/ourios-parquet/tests/rfc0022_promoted_columns.rs
  • crates/ourios-querier/tests/rfc0022_attr_columns.rs
  • docs/rfcs/0022-queryable-attribute-columns.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch rfc0022-red

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves RFC 0022 into the Red gate by flipping its frontmatter status to red and landing the corresponding ignored, compiling-but-failing acceptance-test stubs for all seven §5 scenarios (writer-side in ourios-parquet, query-side in ourios-querier).

Changes:

  • Update RFC 0022 frontmatter status from specifiedred.
  • Add #[ignore]d integration-test stubs for RFC0022.1–.2 (writer projection/encodings) in ourios-parquet.
  • Add #[ignore]d integration-test stubs for RFC0022.3–.7 (query parity, operator gating, pruning, read-path blindness, drift) in ourios-querier.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
docs/rfcs/0022-queryable-attribute-columns.md Flip RFC status to red to reflect entry into the red-test/stub phase.
crates/ourios-querier/tests/rfc0022_attr_columns.rs Add ignored red stubs for query-side RFC 0022 §5 scenarios (.3–.7).
crates/ourios-parquet/tests/rfc0022_promoted_columns.rs Add ignored red stubs for writer-side RFC 0022 §5 scenarios (.1–.2).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants