docs(rfc-0012): draft meta-RFC for CLAUDE.md §2 pillar-#2 wording - #202
Conversation
A meta: RFC (CLAUDE.md is load-bearing; its footer requires a meta: RFC + majority maintainer approval). Pillar #2 currently frames the 50–200× compression as on-disk bytes "before any byte-level codec runs", which RFC 0011 (accepted) refuted — it's a logical reduction whose value is query pruning (B1/B2), not on-disk bytes vs zstd (A1 is a diagnostic). The RFC specifies the exact before/after pillar-#2 wording, the coupled benchmarks.md §2 "Why this bar" reconciliation, §5 doc-state acceptance criteria (RFC0012.1–.3), and the open questions (majority approval; whether §1's thesis sentence wants a parallel touch; the footer changelog line). Per CLAUDE.md §8.5 the edit is NOT made in-session — drafted only; a maintainer enacts after approval. Status: drafted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 2 minutes and 3 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds RFC 0012 as a new 234-line document under ChangesRFC 0012: CLAUDE.md §2 pillar
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Drafts RFC 0012 as a meta-RFC to correct the wording of CLAUDE.md §2 pillar #2 so the “50–200×” figure is framed as a logical reduction whose payoff is query pruning (B1/B2), not an on-disk compression win over byte codecs (A1 is diagnostic per RFC 0011). It also adds the RFC to the mdBook navigation.
Changes:
- Add
docs/rfcs/0012-claude-md-pillar-2-wording.mdwith the proposed wording change, motivation, and acceptance criteria. - Add RFC 0012 to
docs/SUMMARY.mdso it appears in the mdBook RFC list.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/SUMMARY.md | Adds RFC 0012 to the mdBook table of contents under RFCs. |
| docs/rfcs/0012-claude-md-pillar-2-wording.md | Introduces the drafted meta-RFC specifying the CLAUDE.md pillar #2 wording correction and coupled benchmarks.md reconciliation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/rfcs/0012-claude-md-pillar-2-wording.md`:
- Around line 164-166: The acceptance criterion using grep for `50.200`,
`byte.level codec`, and `competent byte codec` is ambiguous because these terms
appear to be potential regex patterns rather than literal strings. Clarify the
acceptance check by explicitly stating that these are literal string matches
(for example, by adding language like "literal grep" or "exact string grep") or
by escaping any special characters to make it unambiguous that fixed-string
matching, not regex matching, is required for verification.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: c8b578ca-dde0-48ab-897a-d24acd4e391d
📒 Files selected for processing (2)
docs/SUMMARY.mddocs/rfcs/0012-claude-md-pillar-2-wording.md
§6 said "the §5.2 grep"; §5.2 is not a section. The grep-based check lives in Scenario RFC0012.2 — reference the scenario id directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot noted §1 claimed "the one coupled paraphrase" but a third spot
carries the same on-disk framing: RFC 0001 §1's summary ("compression
target is 50–200× over raw bytes before any byte-level codec runs").
Reword §1, expand §3.2 to cover both benchmarks.md §2 and RFC 0001 §1
(the latter flagged as an accepted-RFC factual prose fix, maintainer's
call at enactment), and broaden the RFC0012.2 grep to repo-wide.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Three valid review points:
- §3.1 referenced brittle CLAUDE.md line numbers → use the section/item
reference instead.
- §3.2 missed a fourth echo: README.md's template-miner bullet ("before
any byte-level codec runs") — added; the authoritative list is now
whatever the RFC0012.2 framing-grep surfaces.
- RFC0012.2's grep was too broad (`50.200` matches legit logical-reduction
mentions in roadmap/0005). Narrowed to the framing phrases
("before any byte-level codec" / "over a competent byte codec"), which
match exactly the four spots; the bare figure is explicitly left alone.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
All three addressed in the latest commit: (1) §3.1 now references the CLAUDE.md §2 item, not line numbers; (2) added the fourth echo — README.md's template-miner bullet — to §3.2, and reframed the list as "whatever the RFC0012.2 framing-grep surfaces" so it can't silently miss one; (3) RFC0012.2's grep is narrowed to the framing phrases ( |
…lot) RFC0012.2 said "the bare `50.200` figure" using the grep regex form, which reads oddly beside "the 50–200× figure". Reworded to "the framing, not the 50–200× figure itself" — no `50.200` in the prose. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
What
Drafts RFC 0012 — a
meta:RFC proposing a wording fix to CLAUDE.md §2 pillar #2.Why
Pillar #2 reads "this is where the 50–200× compression comes from — before any byte-level codec runs", which frames the figure as on-disk bytes. RFC 0011 (
accepted) refuted that by measurement (ourios does not beat zstd on disk — A1 is a demoted diagnostic). The 50–200× is a logical reduction whose value is query pruning (gates B1/B2), not bytes-vs-codec. The project's load-bearing thesis statement should match its measured reality (benchmarks.mdcalls itself "an honesty contract").What the RFC contains
benchmarks.md§2 "Why this bar" paraphrase (it even misquotes §2 with a "≥ 5× over a competent byte codec" multiplier the pillar never stated) reconciled in the same enactment.Process notes
b50067d).status: drafted. No code/schema; mdBook builds, nav entry added.🤖 Generated with Claude Code
Summary by CodeRabbit