docs(rfc-0001): flip status to validated - #198
Merged
Merged
Conversation
Per the maintainer's 2026-06-14 authorization. The ladder (docs/verification.md §3) reserves `validated` for every thesis-gate the RFC's pillars touch passing on representative corpora (benchmarks.md §7). The template-mining pillar's gates are C1 (reconstruction fidelity) and C2 (template-count convergence) — both pass on a representative ≥ 1 M-line corpus, authoritatively on the §1 baseline hardware (benchmarks.md §9.6: C1 1.000000, C2 a 40-template plateau at 11.2 M lines, formal gate applying). A1 (compression vs zstd) is a diagnostic, not a gate (RFC 0011, already encoded in the §7 gate table). Updates the frontmatter status, the RFC status note, and the roadmap §3 tracker. NB RFC 0011 (the A1 re-scope) is still `drafted`; §7 already reflects the demotion, but accepting RFC 0011 would fully ratify the chain. `accepted` remains the maintainer's terminal sign-off. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRFC 0001 ( ChangesRFC 0001 validated status update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates documentation to reflect RFC 0001 (template miner) advancing to validated on the project’s RFC maturity ladder, based on recorded thesis-gate results on baseline hardware.
Changes:
- Flip RFC 0001 frontmatter
statusfromgreen→validatedand rewrite the RFC’s status note to cite the relevant C1/C2 benchmark evidence. - Update
docs/roadmap.md“Last updated” note and “Current state” section to reflect RFC 0001 asvalidated(and keep RFC 0008 asgreen).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/roadmap.md | Updates roadmap “last updated” note and current-state status line to reflect RFC 0001 validated, with benchmark citations. |
| docs/rfcs/0001-template-miner.md | Updates RFC 0001 frontmatter status and rewrites status note with the rationale/citations for validated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot flagged that "representative ≥ 1 M-line corpus" conflated two thresholds: benchmarks.md §8 defines "representative" as the ≥ 1 GiB canonical floor, while ≥ 1 M-line is C2's formal-gate threshold. HDFS_v1 satisfies both (≈ 1.47 GiB, 11.2 M lines); reword the RFC 0001 status note and the roadmap §3 entry to say so precisely. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…lot) Copilot flagged that bare "§1 baseline hardware" / "§8 canonical floor" refs are ambiguous — each doc has its own §1/§8. Qualify them explicitly as `benchmarks.md` §1 (hardware baseline) and §8 (≥ 1 GiB canonical floor) in the RFC 0001 status note and the roadmap §3 entry + header. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Flips RFC 0001 (template miner) →
validatedon the maturity ladder, per the maintainer's authorization.Why it's validated
docs/verification.md§3 reservesvalidatedfor every thesis-gate the RFC's pillars touch passing on representative corpora (benchmarks.md§7). The template-mining pillar's gates are C1 (reconstruction fidelity) and C2 (template-count convergence):baseline-8vcpu-32gib) inbenchmarks.md§9.6 (identical to the §9.5 diagnostic run — deterministic gates).Changes
docs/rfcs/0001-template-miner.md: frontmatterstatus: green → validated+ status-note rewrite.docs/roadmap.md: §3 status tracker + header.Note (flagged, not blocking)
RFC 0011 (the A1 re-scope that defines C1/C2 as the gates) is still
drafted. The §7 gate table already reflects the A1 demotion, so this flip is well-founded, but accepting RFC 0011 would fully ratify the chain.acceptedremains your terminal sign-off for RFC 0001.Invariants
Doc/status-only. No code, schema, or hot path.
🤖 Generated with Claude Code
Summary by CodeRabbit