Skip to content

docs(rfc-0003): advance status specified → green - #138

Merged
jensholdgaard merged 1 commit into
mainfrom
docs/rfc0003-green
Jun 6, 2026
Merged

docs(rfc-0003): advance status specified → green#138
jensholdgaard merged 1 commit into
mainfrom
docs/rfc0003-green

Conversation

@jensholdgaard

Copy link
Copy Markdown
Owner

What

Advances RFC 0003 (OTLP receiver) specified → green — a doc-only front-matter change.

Per docs/rfcs/README.md, green = "all acceptance criteria pass; unit + property + corpus tests green" — a mechanical/objective gate (only accepted, post-validated, is a maintainer-signoff state). All 15 §5 acceptance scenarios (RFC0003.1–.15) are now live and passing across the receiver crate:

.1 WAL-before-ack · .12 empty fast-path pipeline (#134)
.2 crash-before-ack SIGKILL fixture (#137)
.3 fan-out · .4 resolution-failure tenant (#133)
.5 protobuf · .6 OTLP/JSON decode decode (#129, #131)
.7–.10 materialisation/edge fields materialize (#132)
.11 transport errors · .13 compression · .14 path HTTP (#135) + gRPC (#136)
.15 concurrent WAL-before-ack gRPC (#136)

…plus unit + property (proptest) tests. RFC 0003 defines no corpus test (its §8 uses proptest + hand-curated payloads), so that clause is vacuous here.

Not part of green

  • A served-socket binary wiring the HTTP + gRPC listeners into ourios-server (§9 process-model) — the listeners are currently exercised in-process. This is the natural next step.
  • validated (thesis-gates per benchmarks.md §7) and the maintainer's flip to accepted.

🤖 Generated with Claude Code

All 15 §5 acceptance criteria (RFC0003.1–.15) are live and passing across
the receiver crate (decode, materialisation, tenant fan-out, WAL-before-ack
pipeline, HTTP + gRPC listeners, crash-before-ack), with unit + property
tests green. Per docs/rfcs/README.md the `green` stage is "all acceptance
criteria pass" — a mechanical gate (only `accepted`, post-`validated`, is
a maintainer-signoff state).

Not part of `green`: a served-socket binary wiring the listeners into
ourios-server (§9 process-model — listeners are exercised in-process), and
`validated` thesis-gates.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@jensholdgaard
jensholdgaard requested a review from Copilot June 6, 2026 19:25
@jensholdgaard

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jensholdgaard, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 11 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1eaa764c-0abb-42fb-ae03-452b92135b9e

📥 Commits

Reviewing files that changed from the base of the PR and between 77d809f and 101ae42.

📒 Files selected for processing (1)
  • docs/rfcs/0003-otlp-receiver.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/rfc0003-green

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai

coderabbitai Bot commented Jun 6, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Advances RFC 0003’s maturity status in its frontmatter from specified to green, reflecting that the RFC’s acceptance criteria are now implemented and passing per the RFC process defined in docs/rfcs/README.md.

Changes:

  • Update docs/rfcs/0003-otlp-receiver.md frontmatter status: to green.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jensholdgaard
jensholdgaard merged commit 9bc4e2a into main Jun 6, 2026
11 checks passed
@jensholdgaard
jensholdgaard deleted the docs/rfc0003-green branch June 6, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants