Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioneer to version 0.29 #171

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

speleo3
Copy link
Collaborator

@speleo3 speleo3 commented Oct 21, 2023

Installed versioneer 0.29 with Python 3.12 and ran

versioneer install

Fixes the following error when doing pip install . with Python 3.12:

  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [18 lines of output]
      propka/versioneer.py:421: SyntaxWarning: invalid escape sequence '\s'
        LONG_VERSION_PY['git'] = '''
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "propka/setup.py", line 10, in <module>
          version=versioneer.get_version(),
                  ^^^^^^^^^^^^^^^^^^^^^^^^
        File "propka/versioneer.py", line 1480, in get_version
          return get_versions()["version"]
                 ^^^^^^^^^^^^^^
        File "propka/versioneer.py", line 1412, in get_versions
          cfg = get_config_from_root(root)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^
        File "propka/versioneer.py", line 344, in get_config_from_root
          parser.readfp(f)
          ^^^^^^^^^^^^^
      AttributeError: 'ConfigParser' object has no attribute 'readfp'. Did you mean: 'read'?
      [end of output]

Installed versioneer 0.29 with Python 3.12 and ran

```
versioneer install
```
@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33158d1) 73.05% compared to head (1e5a8c9) 73.09%.
Report is 2 commits behind head on master.

❗ Current head 1e5a8c9 differs from pull request most recent head a03d903. Consider uploading reports for the commit a03d903 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   73.05%   73.09%   +0.04%     
==========================================
  Files          25       25              
  Lines        3989     3988       -1     
==========================================
+ Hits         2914     2915       +1     
+ Misses       1075     1073       -2     
Files Coverage Δ
propka/__init__.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth also bumping up

python-version: ["3.8", "3.9", "3.10", "3.11"]
to include 3.12?

Copy link
Collaborator

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm – I might have to update elsewhere, too

@speleo3
Copy link
Collaborator Author

speleo3 commented Oct 21, 2023

Would it be worth also bumping up to include 3.12?

Yes, good catch.

@speleo3 speleo3 merged commit ee89e36 into jensengroup:master Oct 21, 2023
5 checks passed
@speleo3 speleo3 deleted the versioneer-0.29 branch October 21, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants