Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for py312 #128

Merged
merged 6 commits into from
Oct 21, 2023
Merged

Update for py312 #128

merged 6 commits into from
Oct 21, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 12, 2023

Should just work hopefully.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e08f6c5) 87.56% compared to head (2375f7d) 87.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   87.56%   87.55%   -0.02%     
==========================================
  Files           5        5              
  Lines         748      747       -1     
  Branches      127      127              
==========================================
- Hits          655      654       -1     
  Misses         56       56              
  Partials       37       37              
Files Coverage Δ
gridData/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pep8speaks
Copy link

pep8speaks commented Oct 21, 2023

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 381:80: E501 line too long (84 > 79 characters)
Line 471:80: E501 line too long (80 > 79 characters)
Line 474:80: E501 line too long (84 > 79 characters)

Line 26:80: E501 line too long (80 > 79 characters)
Line 27:80: E501 line too long (86 > 79 characters)
Line 28:80: E501 line too long (81 > 79 characters)
Line 33:80: E501 line too long (83 > 79 characters)
Line 45:80: E501 line too long (83 > 79 characters)
Line 222:80: E501 line too long (87 > 79 characters)
Line 224:80: E501 line too long (86 > 79 characters)
Line 252:80: E501 line too long (85 > 79 characters)
Line 284:80: E501 line too long (87 > 79 characters)
Line 286:80: E501 line too long (83 > 79 characters)
Line 288:80: E501 line too long (86 > 79 characters)
Line 888:80: E501 line too long (85 > 79 characters)
Line 978:80: E501 line too long (80 > 79 characters)
Line 981:80: E501 line too long (87 > 79 characters)
Line 1419:80: E501 line too long (84 > 79 characters)
Line 1620:80: E501 line too long (80 > 79 characters)
Line 1623:80: E501 line too long (84 > 79 characters)
Line 1893:80: E501 line too long (83 > 79 characters)
Line 1988:80: E501 line too long (80 > 79 characters)
Line 1989:80: E501 line too long (85 > 79 characters)
Line 2030:80: E501 line too long (84 > 79 characters)
Line 2032:80: E501 line too long (83 > 79 characters)

Comment last updated at 2023-10-21 07:54:28 UTC

@IAlibay
Copy link
Member Author

IAlibay commented Oct 21, 2023

Thanks to propka for the reminder to bump up versioneer: jensengroup/propka#171

@IAlibay IAlibay requested a review from orbeckst October 21, 2023 14:52
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates, all good from my end.

@@ -0,0 +1,20 @@
# .readthedocs.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the RTD update!

@@ -0,0 +1,12 @@
name: griddata_env
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

# This file is released into the public domain. Generated by
# versioneer-0.18 (https://github.com/warner/python-versioneer)
# This file is released into the public domain.
# Generated by versioneer-0.29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the update!

@orbeckst orbeckst self-assigned this Oct 21, 2023
@orbeckst orbeckst merged commit 8f06972 into master Oct 21, 2023
9 checks passed
@orbeckst orbeckst deleted the py312 branch October 21, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants