Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-70528] Reproducing FilePathDynamicContext-related bug in test #291

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

jglick
Copy link
Member

@jglick jglick commented Feb 15, 2023

#270 handled the common case that the nested node blocks actually ran on distinct agents. It is however possible (when agents have multiple executors) for the nested node to run in a new workspace on the same agent: JENKINS-70528. Trying to extend the earlier fix to handle this case just breaks ws and dir steps.

@jglick jglick added the tests label Feb 15, 2023
@jglick jglick requested a review from a team February 15, 2023 21:56
@jglick
Copy link
Member Author

jglick commented Feb 15, 2023

waiting on jenkins-infra/helpdesk#3391

@jglick
Copy link
Member Author

jglick commented Feb 15, 2023

I have found a cleaner fix. It requires changes in workflow-basic-steps, however. I am again considering moving the dir step into this plugin to make it easier to work on and test it, since it is subtly coupled to this plugin (jenkinsci/workflow-basic-steps-plugin#86 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant