[JENKINS-41854] Recontextualizing FilePath on demand #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n …` message, rather than the actual CWD.
…o make PushdStepTest pass.
…tep should never have been created to begin with.
|
On hold as in jenkinsci/workflow-support-plugin#95 (comment). |
dwnusbaum
approved these changes
Jun 3, 2019
| @@ -90,7 +91,8 @@ public String getPath() { | |||
| FilePath dir = getContext().get(FilePath.class).child(path); | |||
| getContext().get(TaskListener.class).getLogger().println("Running in " + dir); | |||
| getContext().newBodyInvoker() | |||
| .withContext(dir) | |||
| // TODO perhaps should just be moved into workflow-durable-task-step? | |||
There was a problem hiding this comment.
+1 from me, I think it would make sense to keep all core steps that manipulate FilePath in the same plugin. Want to do that now or just leave it as a TODO?
There was a problem hiding this comment.
all core steps that manipulate
FilePath
There are many other steps in this plugin which consume it, including for example PwdStep which you could see as the counterpart to PushdStep. This just happens to be the only one in this plugin which binds it. So, not sure there is a benefit, other than avoiding the need for FilePathDynamicContext to be used across plugin boundaries. No strong feeling at this point.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/workflow-durable-task-step-plugin#101.