Revert fixes related to JENKINS-67351 and JENKINS-67164 #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getCauseOfBlockage in normal scenarios (jenkinsci#188)" This reverts commit 5dab75a.
…ut the associated build is complete (jenkinsci#185)" This reverts commit 9c8d2f4.
Just deprecate for now? |
dwnusbaum
commented
Jan 14, 2022
| @@ -424,23 +423,6 @@ public String getCookie() { | |||
| } | |||
|
|
|||
| @Override public CauseOfBlockage getCauseOfBlockage() { | |||
| if (FlowExecutionList.get().isResumptionComplete()) { | |||
There was a problem hiding this comment.
I think I will preserve this API in workflow-api temporarily after I revert PRs over there just in case users update workflow-api before workflow-durable-task-step, but I will just make it always return false.
6 tasks
car-roll
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #188 and #185 due to problems in jenkinsci/workflow-api-plugin#188 (see jenkinsci/workflow-api-plugin#188 (comment)) which have no obvious fix and so require the
workflow-apiPRs to be reverted. jenkinsci/workflow-api-plugin#188 introduced an API required here after #188, but that API will be removed once the workflow-api PRs are reverted, so we need to revert the PRs here as well.These fixes were generally expected only to apply to uncommon scenarios related to disaster recovery (although they apparently also mattered for regular usage of ci.jenkins.io as mentioned in #185 (comment)), so I think it is ok to revert them for now.