[JENKINS-67351] Do not load Pipelines during PlaceholderTask.getCauseOfBlockage in normal scenarios #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OfBlockage in normal scenarios
jglick
approved these changes
Dec 15, 2021
|
Leaving in draft until jenkinsci/workflow-api-plugin#188 is released. |
12 tasks
jglick
approved these changes
Dec 17, 2021
src/main/java/org/jenkinsci/plugins/workflow/support/steps/ExecutorStepExecution.java
Outdated
Show resolved
Hide resolved
jglick
approved these changes
Dec 17, 2021
car-roll
approved these changes
Dec 17, 2021
|
There is a typo in the PR title; it refers to the nonexistent JENKINS-67531, rather than JENKINS-67351. This has propagated to the 1107.v5dab75aaccbd release notes and to the plugin page, as well. |
dwnusbaum
changed the title
6 tasks
dwnusbaum
added a commit
to dwnusbaum/workflow-durable-task-step-plugin
that referenced
this pull request
Jan 14, 2022
…getCauseOfBlockage in normal scenarios (jenkinsci#188)" This reverts commit 5dab75a.
This was referenced Jan 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-67351 and jenkinsci/workflow-api-plugin#188. Amends #185.
One of the stack traces related to JENKINS-67351 (from the jenkinsci-users mailing list) indicated that a build being accessed in
PlaceholderTask.getCauseOfBlockagewas not yet loaded becauseFlowExecutionList$ItemListenerImpl.onLoadedhad not executed yet. I did not think this was possible in #185 (comment), and we do not want to be loading Pipelines while the queue lock is held in normal scenarios.