Code cleanup #140
Merged
Code cleanup #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g.hamcrest.MatcherAssert.assertThat
|
Two test failures, one I think is a legitimate flaky test, and I am investigating in #133. The other looks like a CI infra issue:
Perhaps they are both caused by the infra issue, but I'm not sure. |
dwnusbaum
approved these changes
Aug 17, 2020
| @@ -193,7 +191,7 @@ public void stop(Throwable cause) throws Exception { | |||
| } | |||
| Jenkins j = Jenkins.getInstanceOrNull(); | |||
| if (j != null) { | |||
| COMPUTERS: for (Computer c : j.getComputers()) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A series of code cleanup changes for this repository. Most of these changes remove usages of deprecated functionality or otherwise fix IDE warnings. I kept each commit separate. Each commit message should be self-explanatory, but if anything is unclear I am happy to provide further explanation. I suggest ignoring whitespace changes in the GitHub UI when reviewing
f06bd78. Also, feel free to revert any specific cleanup commits that are unwanted.