[JENKINS-73259] Migrate Winstone from EE 8 to EE 9 #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
force-pushed
the
prototype
branch
2 times, most recently
from
2f132aa to
8a9cfa5
Compare
basil
force-pushed
the
jakarta
branch
2 times, most recently
from
32221fa to
b1d3d08
Compare
This comment was marked as spam.
This comment was marked as spam.
basil
force-pushed
the
jakarta
branch
3 times, most recently
from
577f7c5 to
0b02e4e
Compare
This was referenced Aug 28, 2024
alecharp
approved these changes
Aug 28, 2024
basil
commented
Aug 28, 2024
src/main/java/winstone/Launcher.java
Outdated
| @@ -183,7 +182,7 @@ public Launcher(Map<String, String> args) throws IOException { | |||
| } | |||
|
|
|||
| // JENKINS-73616: Turn down log level of annotation parser | |||
| java.util.logging.Logger logger = java.util.logging.Logger.getLogger(AnnotationParser.class.getName()); | |||
| java.util.logging.Logger logger = java.util.logging.Logger.getLogger("org.eclipse.jetty.ee9.annotations.AnnotationParser"); | |||
There was a problem hiding this comment.
This annotation is no longer on our classpath in EE 9 due to some upstream cleanup in the Jetty dependency tree, so just use a string constant.
MarkEWaite
approved these changes
Aug 29, 2024
daniel-beck
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Goes with three other pull requests:
Description
Replace dependencies with EE 9 versions in
pom.xmland update all relevant imports.Testing done
Full PCT/ATH