[JENKINS-73256] Migrate Jelly from EE 8 to EE 9 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkEWaite
approved these changes
Jun 27, 2024
NotMyFault
approved these changes
Jun 27, 2024
basil
force-pushed
the
jakarta
branch
2 times, most recently
from
7574b7b to
1f5f563
Compare
timja
approved these changes
Jul 15, 2024
This was referenced Aug 28, 2024
alecharp
approved these changes
Aug 28, 2024
BorisYaoA
approved these changes
Aug 28, 2024
vwagh-dev
approved these changes
Aug 28, 2024
daniel-beck
approved these changes
Sep 3, 2024
Comment on lines
230
to
+234
| SQL_MAXROWS_PARSE_ERROR=\ | ||
| Error parsing 'javax.servlet.jsp.jstl.sql.maxRows' configuration setting: "{0}" | ||
| Error parsing 'jakarta.servlet.jsp.jstl.sql.maxRows' configuration setting: "{0}" | ||
|
|
||
| SQL_MAXROWS_INVALID=\ | ||
| 'javax.servlet.jsp.jstl.sql.maxRows' configuration setting neither an Integer nor a String | ||
| 'jakarta.servlet.jsp.jstl.sql.maxRows' configuration setting neither an Integer nor a String |
There was a problem hiding this comment.
We don't use jelly-sql anywhere I think?
There was a problem hiding this comment.
Correct. This change is only for logical consistency with the jakarta.servlet.jsp.jstl-api bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Goes with three other pull requests:
Description
Replace dependencies with EE 9 versions in
pom.xmland update all relevant imports.Testing done
Full PCT/ATH